Bug 39350

Summary: Add support for handling basic <script> tags in the HTML5 Parser
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Patch
none
A patch that actually works abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2010-05-19 01:54:02 PDT
Add support for handling basic <script> tags in the HTML5 Parser
Attachments
Patch (2.93 KB, patch)
2010-05-19 02:00 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
A patch that actually works (3.25 KB, patch)
2010-05-19 02:10 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-05-19 02:00:30 PDT
Created attachment 56476 [details] Patch
Early Warning System Bot
Comment 2 2010-05-19 02:04:54 PDT
Attachment 56476 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2264310
Eric Seidel (no email)
Comment 3 2010-05-19 02:07:14 PDT
Attachment 56476 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/2318302
Eric Seidel (no email)
Comment 4 2010-05-19 02:10:42 PDT
Created attachment 56477 [details] A patch that actually works
Eric Seidel (no email)
Comment 5 2010-05-19 02:31:30 PDT
Comment on attachment 56477 [details] A patch that actually works The attached patch works enough to make: <div>Hello</div> <script> alert(42) </script> <div>Bye</div> work. The rest of the HTML5 parser isn't complete enough to make html5lib/runner.html work yet though.
Adam Barth
Comment 6 2010-05-19 08:08:30 PDT
Comment on attachment 56477 [details] A patch that actually works Looks reasonable. We'll probably need to move this somewhere else. I tested this locally and it worked.
Eric Seidel (no email)
Comment 7 2010-05-19 12:02:49 PDT
Committed r59778: <http://trac.webkit.org/changeset/59778>
Note You need to log in before you can comment on or make changes to this bug.