Bug 3821

Summary: GW: add KWQWMatrix white-room implementation
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 3250    
Attachments:
Description Flags
adds a real qwmatrix implementation, and removes stub from KWQPixmap.h
mjs: review-
Fixes the two issues mjs raised
mjs: review+
project file diff mjs: review+

Eric Seidel (no email)
Reported 2005-07-02 18:47:02 PDT
Attached is my white-room implementation of KWQWMatrix. It's very simple and uses CGAffineTransform for everything. But it's enough to get other projects up and running correctly on KWQ.
Attachments
adds a real qwmatrix implementation, and removes stub from KWQPixmap.h (7.68 KB, patch)
2005-07-02 20:04 PDT, Eric Seidel (no email) 		mjs: review-
DetailsFormatted DiffDiff
Fixes the two issues mjs raised (7.96 KB, patch)
2005-07-03 15:09 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
project file diff (1.78 KB, patch)
2005-07-05 00:33 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-07-02 20:04:01 PDT
Created attachment 2761 [details] adds a real qwmatrix implementation, and removes stub from KWQPixmap.h
Maciej Stachowiak
Comment 2 2005-07-03 03:47:44 PDT
Comment on attachment 2761 [details] adds a real qwmatrix implementation, and removes stub from KWQPixmap.h Seems like both your comments here are right. QWMatrix indeed takes degrees while CGAffineTransform takes radians. And the behavior of invert() on a singular matrix would not match between Qt and CG.
Eric Seidel (no email)
Comment 3 2005-07-03 15:09:12 PDT
Created attachment 2776 [details] Fixes the two issues mjs raised
Eric Seidel (no email)
Comment 4 2005-07-05 00:33:49 PDT
Created attachment 2801 [details] project file diff
Maciej Stachowiak
Comment 5 2005-07-05 01:39:27 PDT
Comment on attachment 2801 [details] project file diff r=me assuming you tested
Note You need to log in before you can comment on or make changes to this bug.