Bug 38116

(In reply to comment #0) > In webkit, invalid media query values are ignored and treated as empty values. > For example (-webkit-view-mode) and (-webkit-view-mode:blah) will both be > evaluated the same although blah is not a valid view mode value. Just to make it clear, the blah is a no-accepted keyword.

Created attachment 54281 [details] patch 1

Comment on attachment 54281 [details] patch 1 WebCore/ChangeLog:19 + corrected here. After landing this patch it will. The following corrects the view I dont think you should add things like "after landing this patch" in the ChangeLog WebCore/css/CSSValueKeywords.in:718 + windowed This belongs to another patch. It is not related. WebCore/css/MediaQueryExp.h:55 + bool valueParseError() const { return m_valueParseError; } I do not like the name of the method. What about valueIsValid() or so?

Created attachment 54291 [details] patch 2

Attachment 54291 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/css/MediaQueryExp.cpp:77: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 54293 [details] patch 2

Attachment 54293 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/css/MediaQueryExp.cpp:77: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 54297 [details] patch 3 correcting style error.

Please provide a link to the spec that describes how such media queries should be processed.

Comment on attachment 54297 [details] patch 3 Rejecting patch 54297 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12730 test cases. fast/media/media-query-invalid-value.html -> failed Exiting early after 1 failures. 7902 tests run. 142.89s total testing time 7901 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 4 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1816138

Created attachment 54436 [details] patch 4

(In reply to comment #9) > Please provide a link to the spec that describes how such media queries should > be processed. The spec is at http://www.w3.org/TR/css3-mediaqueries/#error-handling

Comment on attachment 54436 [details] patch 4 > diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog > index d2e0b8c..22cf7d4 100644 > --- a/LayoutTests/ChangeLog > +++ b/LayoutTests/ChangeLog > @@ -1,3 +1,16 @@ > +2010-04-27 Luiz Agostini <luiz.agostini@openbossa.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Media queries empty values > + https://bugs.webkit.org/show_bug.cgi?id=38116 > + > + Adding isValid() method to MediaQueryExp to be possible to differentiate > + between queries with empty values and queries with invalid values. .. to make it possible to differentiate... r=me

Created attachment 54596 [details] patch 5

Comment on attachment 54596 [details] patch 5 Clearing flags on attachment: 54596 Committed r58479: <http://trac.webkit.org/changeset/58479>

All reviewed patches have been landed. Closing bug.

Revision r58479 cherry-picked into qtwebkit-2.0 with commit 9ee650877afa91d7941d98803d1fb23840201c9b