Bug 37635

Summary: Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: AccessibilityAssignee: Antonio Gomes <tonikitoo>
Status: CLOSED FIXED    
Severity: Normal CC: dglazkov, eric, gustavo, hausmann, kenneth, simon.fraser, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 18662    
Bug Blocks: 35784    
Attachments:
Description Flags
patch v1
tonikitoo: commit-queue-
(committed: r57663) patch v2 none

Antonio Gomes
Reported 2010-04-14 21:11:32 PDT
absoluteClippedOverflowRect implemention does return an empty rect for offscreen nodes. so hasOffscreenRect (SpatialNavigation.cpp) can bail out earlier in such cases. see related discussion in webkit-dev in [1] [1] http://lists.macosforge.org/pipermail/webkit-dev/2010-March/012075.html
Attachments
patch v1 (2.22 KB, patch)
2010-04-14 21:17 PDT, Antonio Gomes 		tonikitoo: commit-queue-
DetailsFormatted DiffDiff
(committed: r57663) patch v2 (2.15 KB, patch)
2010-04-15 08:15 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-04-14 21:17:04 PDT
Created attachment 53405 [details] patch v1
WebKit Review Bot
Comment 2 2010-04-14 21:20:14 PDT
Attachment 53405 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1591506
WebKit Review Bot
Comment 3 2010-04-14 21:23:12 PDT
Attachment 53405 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1552523
Eric Seidel (no email)
Comment 4 2010-04-14 21:23:31 PDT
Attachment 53405 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1689241
Early Warning System Bot
Comment 5 2010-04-14 21:24:44 PDT
Attachment 53405 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1686255
Antonio Gomes
Comment 6 2010-04-15 08:15:05 PDT
Created attachment 53438 [details] (committed: r57663) patch v2 same as patch v1, but un-bitrotted and builds
Antonio Gomes
Comment 7 2010-04-15 12:39:44 PDT
Comment on attachment 53438 [details] (committed: r57663) patch v2 Clearing flags on attachment: 53438 Committed r57663: <http://trac.webkit.org/changeset/57663>
Antonio Gomes
Comment 8 2010-04-15 12:40:52 PDT
Thank you Simon Fraser!
Simon Hausmann
Comment 9 2010-04-20 13:22:10 PDT
Revision r57663 cherry-picked into qtwebkit-2.0 with commit bf61de5859ad29d41a76791862ac4c02b336d6da
Note You need to log in before you can comment on or make changes to this bug.