Bug 37100

Summary: [Symbian] Consolidate Symbian WINSCW environment configuration
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, kenneth
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
proposed patch
none
2nd try, remove extra whitespace none

Laszlo Gombos
Reported 2010-04-05 11:26:22 PDT
WINSCW is a cross-compilation environment running on Windows. For this environment WIN32, OS(WIN) and PLATFORM(WIN) should not be defined. Currently some of this logic is in WebCore/config.h and some in JavaScriptCore/wtf/Platform.h. It make sense to consolidate this logic into Platform.h as this is related to global environment setup for WINSCW. For example after r56623 WIN32 is _not_ defined when compiling WebCore with WINSCW but it is defined when compiling JavaScriptCore. This can lead to hard-to-find build issues.
Attachments
proposed patch (2.60 KB, patch)
2010-04-05 11:32 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
2nd try, remove extra whitespace (2.45 KB, patch)
2010-04-05 11:34 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-04-05 11:32:24 PDT
Created attachment 52547 [details] proposed patch
Laszlo Gombos
Comment 2 2010-04-05 11:34:27 PDT
Created attachment 52548 [details] 2nd try, remove extra whitespace
WebKit Commit Bot
Comment 3 2010-04-05 17:55:25 PDT
Comment on attachment 52548 [details] 2nd try, remove extra whitespace Clearing flags on attachment: 52548 Committed r57108: <http://trac.webkit.org/changeset/57108>
WebKit Commit Bot
Comment 4 2010-04-05 17:55:30 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 5 2010-04-06 02:55:49 PDT
<cherry-pick-for-backport: r57076>
Simon Hausmann
Comment 6 2010-04-06 02:59:47 PDT
Revision r57076 cherry-picked into qtwebkit-2.0 with commit ac69c2f69372089990b04b3425da1d2eb2697ae0 Revision r57108 cherry-picked into qtwebkit-2.0 with commit 5bfb5ac38f9981f950c7116001844d3f7b681d67
Note You need to log in before you can comment on or make changes to this bug.