Bug 37009

Summary: The master commit-queue process should take responsibility for checking that the builders are green
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2010-04-01 21:53:09 PDT
The master commit-queue process should take responsibility for checking that the builders are green
Attachments
Patch (1.66 KB, patch)
2010-04-01 21:53 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2010-04-01 22:17 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-01 21:53:56 PDT
Created attachment 52374 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-01 22:00:38 PDT
Comment on attachment 52374 [details] Patch + "--ignore-builders", That change needs a comment to later developers that that's right, and remind them not to remove the builders_are_green check above! :)
Adam Barth
Comment 3 2010-04-01 22:17:31 PDT
Created attachment 52376 [details] Patch
Adam Barth
Comment 4 2010-04-02 01:18:54 PDT
Comment on attachment 52376 [details] Patch Clearing flags on attachment: 52376 Committed r56986: <http://trac.webkit.org/changeset/56986>
Adam Barth
Comment 5 2010-04-02 01:18:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.