Bug 36918

Summary: set-progress-properties.html expected result should not be platform specific
Product: WebKit Reporter: Yael <yael>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch to move the test result none

Yael
Reported 2010-03-31 18:46:17 PDT
Originally, the expected result was committed under LayoutTests\platform\qt. This JavaScript based test should have the same result for all platforms that do not skip the test.
Attachments
Patch to move the test result (3.43 KB, patch)
2010-03-31 18:56 PDT, Yael 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2010-03-31 18:56:26 PDT
Created attachment 52235 [details] Patch to move the test result
Laszlo Gombos
Comment 2 2010-04-01 06:32:18 PDT
Comment on attachment 52235 [details] Patch to move the test result It looks correct to me move the expected file to the common set, r+.
WebKit Commit Bot
Comment 3 2010-04-01 06:51:27 PDT
Comment on attachment 52235 [details] Patch to move the test result Rejecting patch 52235 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12599 test cases. fast/canvas/webgl/index-validation.html -> failed Exiting early after 1 failures. 5076 tests run. 81.01s total testing time 5075 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1666025
Yael
Comment 4 2010-04-01 06:56:00 PDT
Comment on attachment 52235 [details] Patch to move the test result This patch is moving an expected result around. It is most likely not the reason for fast/canvas/webgl/index-validation.html to fail.
WebKit Commit Bot
Comment 5 2010-04-01 07:13:03 PDT
Comment on attachment 52235 [details] Patch to move the test result Clearing flags on attachment: 52235 Committed r56912: <http://trac.webkit.org/changeset/56912>
WebKit Commit Bot
Comment 6 2010-04-01 07:13:08 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 7 2010-04-01 11:24:54 PDT
Correct. You hit bug 36908.
Note You need to log in before you can comment on or make changes to this bug.