Bug 36011

Summary: Add TextEncoding::usesBackslashAsCurrencySymbol()
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 24906    
Attachments:
Description Flags
Patch v1 darin: review-

Shinichiro Hamaji
Reported 2010-03-11 05:12:08 PST
This function will be used by Bug 24906 to implement transcoding based on both fonts and encodings.
Attachments
Patch v1 (1.80 KB, patch)
2010-03-11 05:14 PST, Shinichiro Hamaji 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-03-11 05:14:13 PST
Created attachment 50488 [details] Patch v1
Darin Adler
Comment 2 2010-03-12 09:17:07 PST
Comment on attachment 50488 [details] Patch v1 The logic here is backwards. This changes some "==" to "!=". As a side note, I also personally don’t think this refactoring is an improvement. The old code seems clearer to me.
Shinichiro Hamaji
Comment 3 2010-03-15 00:31:08 PDT
> The logic here is backwards. This changes some "==" to "!=". Oops. Sorry for the mistake... > As a side note, I also personally don’t think this refactoring is an > improvement. The old code seems clearer to me. I see. So, I think I will make backslashAsCurrencySymbol() public when I will use. Making this issue WONTFIX...
Note You need to log in before you can comment on or make changes to this bug.