Bug 35891

Summary: [GStreamer] Fails to go to Loaded state because of floating point discrepancies
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: MediaAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 9243    
Attachments:
Description Flags
try to avoid the floating point comparison by using the fill status variable gustavo: commit-queue-

Gustavo Noronha (kov)
Reported 2010-03-08 15:37:13 PST
Watching debug logs I noticed that maxTimeLoaded was getting very close to, but not exactly equal to duration. I think we need to stop relying on the floating point calculations for the 'completed' case.
Attachments
try to avoid the floating point comparison by using the fill status variable (2.16 KB, patch)
2010-03-08 15:40 PST, Gustavo Noronha (kov) 		gustavo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2010-03-08 15:40:05 PST
Created attachment 50261 [details] try to avoid the floating point comparison by using the fill status variable
Philippe Normand
Comment 2 2010-03-09 00:05:12 PST
LGTM!
Eric Seidel (no email)
Comment 3 2010-03-24 14:32:34 PDT
Attachment 50261 [details] was posted by a committer and has review+, assigning to Gustavo Noronha Silva for commit.
Gustavo Noronha (kov)
Comment 4 2010-03-24 16:02:37 PDT
Comment on attachment 50261 [details] try to avoid the floating point comparison by using the fill status variable Finally got this committed as r56465. Thanks!
Note You need to log in before you can comment on or make changes to this bug.