Bug 35695

Attachment 49932 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Last 3072 characters of output: [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:102: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:106: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:119: Use 0 instead of NULL. [readability/null] [4] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:157: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:163: Use 0 instead of NULL. [readability/null] [4] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:258: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:259: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:48: font_extents is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:49: text_extents is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:101: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:126: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp" WebCore/platform/graphics/cairo/FontCacheCairo.cpp:43: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontCacheCairo.cpp:48: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontCustomPlatformData.h:27: cairo_font_face_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/cairo/FontCustomPlatformData.cpp:25: Alphabetical sorting problem. [build/include_order] [4] WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontPlatformData.h" WebCore/platform/graphics/cairo/FontPlatformData.h:32: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/graphics/cairo/FontPlatformData.h:104: Place brace on its own line for function definitions. [whitespace/braces] [4] WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp" WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp" WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp" WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontCacheGtk.cpp" Total errors found: 20 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 49932 [details] Move font code from platform/graphics/gtk to ../cairo I think the move makes sense. I would like to have this change be done in two separate parts, though: one patch for the move, one patch for the efl-changes (adding the preprocessor conditionals, for instance). This will make it less likely that we are going to cause an issue we will have a hard time identifying.

Created attachment 49938 [details] Move font code from platform/graphics/gtk to ../cairo Updated patch, so it only move files around.

Attachment 49938 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Last 3072 characters of output: [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:99: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:103: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:115: Use 0 instead of NULL. [readability/null] [4] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:150: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:155: Use 0 instead of NULL. [readability/null] [4] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:247: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp:248: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:48: font_extents is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:49: text_extents is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:101: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:126: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp" WebCore/platform/graphics/cairo/FontCacheCairo.cpp:43: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontCacheCairo.cpp:48: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/cairo/FontCustomPlatformData.h:27: cairo_font_face_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/cairo/FontCustomPlatformData.cpp:25: Alphabetical sorting problem. [build/include_order] [4] WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontPlatformData.h" WebCore/platform/graphics/cairo/FontPlatformData.h:32: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/graphics/cairo/FontPlatformData.h:104: Place brace on its own line for function definitions. [whitespace/braces] [4] WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp" WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp" WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp" WARNING: Could not read file. Skipping: "WebCore/platform/graphics/gtk/FontCacheGtk.cpp" Total errors found: 20 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 49938 [details] Move font code from platform/graphics/gtk to ../cairo OK, EWS seems happy.

Comment on attachment 49938 [details] Move font code from platform/graphics/gtk to ../cairo Clearing flags on attachment: 49938 Committed r55510: <http://trac.webkit.org/changeset/55510>

All reviewed patches have been landed. Closing bug.