Bug 35539

Summary:

New port: EFL; adding files to WebCore/graphics/efl (patch 2 of 4)

Product:

WebKit

Reporter:

Leandro Pereira <leandro>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

barbieri, commit-queue, eric, gustavo, gyuyoung.kim, kenneth, oliver, rakuco, tonikitoo, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Add files to WebCore/platform/graphics/efl (patch 2/4)	none
Add EFL port files in WebCore/platform/graphics/efl (patch 2/2)	kenneth: review-
Add EFL port files to WebCore/platform/graphics/efl (2/2)	none

Leandro Pereira

Reported 2010-03-01 13:01:38 PST

+++ This bug was initially created as a clone of Bug #35531 +++ +++ This bug was initially created as a clone of Bug #35087 +++

Attachments
Add files to WebCore/platform/graphics/efl (patch 2/4) (18.78 KB, patch) 2010-03-01 13:02 PST, Leandro Pereira	no flags	Details Formatted Diff Diff
Add EFL port files in WebCore/platform/graphics/efl (patch 2/2) (13.39 KB, patch) 2010-03-02 11:34 PST, Leandro Pereira	kenneth: review-	Details Formatted Diff Diff
Add EFL port files to WebCore/platform/graphics/efl (2/2) (12.51 KB, patch) 2010-03-04 06:27 PST, Leandro Pereira	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Leandro Pereira

Comment 1 2010-03-01 13:02:11 PST

Created attachment 49743 [details] Add files to WebCore/platform/graphics/efl (patch 2/4)

Kenneth Rohde Christiansen

Comment 2 2010-03-01 13:03:45 PST

Comment on attachment 49743 [details] Add files to WebCore/platform/graphics/efl (patch 2/4) You don't split your patches very logically... This patch has Gstreamer code, but the previous one had as well, mixing it with IntRect, Image code etc. You should really make one patch with all media related code etc. Try to split the patches logically.

Leandro Pereira

Comment 3 2010-03-01 13:57:55 PST

(In reply to comment #2) > (From update of attachment 49743 [details]) > You should really make one patch with all media related code etc. Try to split > the patches logically. These patches were splitted by a script I wrote. This script only checks for the final patch size: it doesn't group the files per feature or similarity. The port is quite large to split everything by hand (not to say it is error prone), and making the script aware of related code would take time I don't have.

Kenneth Rohde Christiansen

Comment 4 2010-03-02 03:48:14 PST

Do a sort of the files and look for similar names? Shouldn't take much time to code. Landing takes time, so if you are interested in landing and maintaining a new port, which your team has voiced on the mailing list, you should definitely have the time for landing the initial patches correctly. The reviewers are doing a service for you, so it is your job making it as easy as possible for them.

Leandro Pereira

Comment 5 2010-03-02 11:34:14 PST

Created attachment 49825 [details] Add EFL port files in WebCore/platform/graphics/efl (patch 2/2)

Kenneth Rohde Christiansen

Comment 6 2010-03-02 12:01:28 PST

Comment on attachment 49825 [details] Add EFL port files in WebCore/platform/graphics/efl (patch 2/2) I don't know enough to say if the GlyphPage part is correct, but the rest looks good to me. I guess that GlyphPage code is similar to the GTK+ one right?

Leandro Pereira

Comment 7 2010-03-02 12:35:03 PST

(In reply to comment #6) > (From update of attachment 49825 [details]) > I don't know enough to say if the GlyphPage part is correct, but the rest looks > good to me. I guess that GlyphPage code is similar to the GTK+ one right? They're identical, actually. Moving it to platform/graphics/cairo would make sense.

Kenneth Rohde Christiansen

Comment 8 2010-03-02 13:00:35 PST

Comment on attachment 49825 [details] Add EFL port files in WebCore/platform/graphics/efl (patch 2/2) r- for above reason.

Leandro Pereira

Comment 9 2010-03-03 12:34:58 PST

(In reply to comment #8) > (From update of attachment 49825 [details]) > r- for above reason. I've submitted bug #35695, which moves these files to a neutral cairo directory.

Leandro Pereira

Comment 10 2010-03-04 06:27:01 PST

Created attachment 50009 [details] Add EFL port files to WebCore/platform/graphics/efl (2/2)

WebKit Commit Bot

Comment 11 2010-03-04 07:41:50 PST

Comment on attachment 50009 [details] Add EFL port files to WebCore/platform/graphics/efl (2/2) Clearing flags on attachment: 50009 Committed r55526: <http://trac.webkit.org/changeset/55526>

WebKit Commit Bot

Comment 12 2010-03-04 07:41:56 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.