Bug 35151
| Summary: | check-webkit-style should ignore "config.h" rule inside Qt autotests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jędrzej Nowacki <jedrzej.nowacki> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | cmarcelo, kent.hansen, zoltan |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Jędrzej Nowacki
check-webkit-style should ignore "config.h" rule inside directories:
JavaScriptCore/qt/tests/
WebKit/qt/tests/
These directories contain autotests, that are not part of the WebKit library and it is not possible to compile them with the include.
Use case: bug 34843
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tor Arne Vestbø
Please follow the QtWebKit bug reporting guidelines when reporting bugs.
See http://trac.webkit.org/wiki/QtWebKitBugs
Specifically:
- The 'QtWebKit' component should only be used for bugs/features in the
public QtWebKit API layer, not to signify that the bug is specific to
the Qt port of WebKit
http://trac.webkit.org/wiki/QtWebKitBugs#Component
- Add the keyword 'Qt' to signal that it's a Qt-related bug
http://trac.webkit.org/wiki/QtWebKitBugs#Keywords
Zoltan Horvath
check-webkit-style ignores these, see r76530
(http://trac.webkit.org/changeset/76530/trunk/Tools/Scripts/webkitpy/style/checker.py)
*** This bug has been marked as a duplicate of bug 53017 ***