Bug 34506

Summary: LayoutTests/storage/database-lock-after-reload.html needs to be refactored and made less flaky
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Dumitru Daniliuc <dumi>
Status: RESOLVED FIXED    
Severity: Normal CC: michaeln
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch dglazkov: review+, dumi: commit-queue-

Dumitru Daniliuc
Reported 2010-02-02 17:44:14 PST
database-lock-after-reload.html has a few problems: 1. Uses the same 'errorFunction' as a statement error callback and transaction error callback. This is not OK, because the two error callbacks have different signatures. 2. Uses RANDOMBLOB which is disallowed by the authorizer. The fact that the test still passes sometimes shows how irrelevant/flaky some operations are. 3. It tries to insert a big enough BLOB in the database, to keep the database thread busy while the main thread navigates to a different page. A 0.5MB BLOB can hardly be considered big enough for this. 4. Some trailing whitespaces.
Attachments
patch (5.20 KB, patch)
2010-03-02 18:25 PST, Dumitru Daniliuc
dglazkov: review+
dumi: commit-queue-
Dumitru Daniliuc
Comment 1 2010-03-02 18:25:06 PST
Created attachment 49873 [details] patch The flakiness of this test should be completely removed by the fix to bug 35624.
Dimitri Glazkov (Google)
Comment 2 2010-03-03 13:08:16 PST
Comment on attachment 49873 [details] patch ok.
Dumitru Daniliuc
Comment 3 2010-03-03 17:21:44 PST
Landed as r55490.
Note You need to log in before you can comment on or make changes to this bug.