Bug 34400

Summary: Web Inspector: Fix rest of the NativeTextViewer (line numbers, conditional breakpoints, selection).
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change. timothy: review+

Pavel Feldman
Reported 2010-01-31 13:55:18 PST
Some more testing and we are ready to flip the preferences bit.
Attachments
[PATCH] Proposed change. (10.06 KB, patch)
2010-01-31 13:57 PST, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-01-31 13:57:40 PST
Created attachment 47799 [details] [PATCH] Proposed change.
Timothy Hatcher
Comment 2 2010-01-31 14:00:23 PST
Comment on attachment 47799 [details] [PATCH] Proposed change. > + return nextElement.offsetTop - element.offsetTop; > + } else > + return element.parentElement.offsetHeight - element.offsetTop; NO need for the "} else" after a return.
Pavel Feldman
Comment 3 2010-02-01 06:07:12 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/NativeTextViewer.js M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/SourceFrame.js M WebCore/inspector/front-end/TextEditor.js M WebCore/inspector/front-end/inspector.css M WebCore/inspector/front-end/textEditor.css Committed r54133
Note You need to log in before you can comment on or make changes to this bug.