Bug 34009

Summary: Don't go into compositing mode for 0x0 plugins
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ismail, mitz
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
WIP patch
none
Patch mitz: review+

Simon Fraser (smfr)
Reported 2010-01-22 11:07:22 PST
Followup from bug 33821: there's no point in going into compositing mode for a 0x0 plugin
Attachments
WIP patch (2.69 KB, patch)
2010-07-07 22:53 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (29.01 KB, patch)
2010-07-12 17:00 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2010-05-03 12:54:48 PDT
<rdar://problem/7935757>
Simon Fraser (smfr)
Comment 2 2010-07-06 16:54:34 PDT
This isn't as simple as it would appear to be, because we can't look at the renderer size from updateStyle() (where we make compositing decisions), because layout hasn't happened yet.
Simon Fraser (smfr)
Comment 3 2010-07-07 22:53:45 PDT
Created attachment 60843 [details] WIP patch
Simon Fraser (smfr)
Comment 4 2010-07-11 11:27:45 PDT
Sites to test: gmail.com Mobile Me "Find my iPhone" yahoo mail
Simon Fraser (smfr)
Comment 5 2010-07-12 17:00:00 PDT
Created attachment 61294 [details] Patch
Simon Fraser (smfr)
Comment 6 2010-07-12 17:38:57 PDT
I filed bug 42120 to optimize m_compositingDependsOnGeometry.
Simon Fraser (smfr)
Comment 7 2010-07-12 17:42:10 PDT
http://trac.webkit.org/changeset/63149
Note You need to log in before you can comment on or make changes to this bug.