Bug 33895

Summary: Make run-webkit-tests work under Cygwin for the Qt port
Product: WebKit Reporter: Tor Arne Vestbø <vestbo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, eric, hausmann, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Changed crlf conversion to using binmode, and only on cygwin none

Tor Arne Vestbø
Reported 2010-01-20 04:38:13 PST
Make run-webkit-tests work under Cygwin for the Qt port
Attachments
Patch (11.61 KB, patch)
2010-01-20 04:45 PST, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Changed crlf conversion to using binmode, and only on cygwin (11.34 KB, patch)
2010-01-22 08:25 PST, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2010-01-20 04:45:09 PST
Created attachment 47008 [details] Patch
Tor Arne Vestbø
Comment 2 2010-01-20 04:46:22 PST
Comment on attachment 47008 [details] Patch Addec cq flag to make this patch land though the cq, which runs run-webkit-tests on the core builders first. This should hopefully catch any problems I overlooked.
Simon Hausmann
Comment 3 2010-01-20 06:22:25 PST
Comment on attachment 47008 [details] Patch LGTM
Tor Arne Vestbø
Comment 4 2010-01-20 06:33:41 PST
Comment on attachment 47008 [details] Patch cq- for now, as I want to be present when this thing lands to make sure everything works.
Tor Arne Vestbø
Comment 5 2010-01-22 03:37:10 PST
Comment on attachment 47008 [details] Patch Trying to cq this now that the cq is running and I'm watching :)
WebKit Commit Bot
Comment 6 2010-01-22 04:14:10 PST
Comment on attachment 47008 [details] Patch Rejecting patch 47008 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12034 test cases. fast/dom/simultaneouslyRegsiteredTimerFireOrder.html -> failed Exiting early after 1 failures. 5685 tests run. 86.16s total testing time 5684 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/203757
Tor Arne Vestbø
Comment 7 2010-01-22 08:25:35 PST
Created attachment 47207 [details] Changed crlf conversion to using binmode, and only on cygwin
Tor Arne Vestbø
Comment 8 2010-01-22 08:26:19 PST
Comment on attachment 47207 [details] Changed crlf conversion to using binmode, and only on cygwin Add cq? to make it land though the cq which runs webkit tests
WebKit Commit Bot
Comment 9 2010-01-22 22:51:48 PST
Comment on attachment 47207 [details] Changed crlf conversion to using binmode, and only on cygwin Clearing flags on attachment: 47207 Committed r53763: <http://trac.webkit.org/changeset/53763>
WebKit Commit Bot
Comment 10 2010-01-22 22:51:53 PST
All reviewed patches have been landed. Closing bug.
Brian Weinstein
Comment 11 2010-01-23 17:51:18 PST
This broke the Windows tests. Since r53763 it has been exiting with 20 failures after 66 tests run. Do you know a fix or should we roll this out?
Eric Seidel (no email)
Comment 12 2010-01-24 14:07:16 PST
You should always feel welcome to immediately roll out any commit from me (or the commit-bot). I'm in the process of making a bot to do that automatically if things break. I can always roll back in changes if necessary. Rolling this out now.
Eric Seidel (no email)
Comment 13 2010-01-24 14:15:49 PST
Reverted r53763 for reason: Broke 20+ tests on Windows. Committed r53783: <http://trac.webkit.org/changeset/53783>
Tor Arne Vestbø
Comment 14 2010-02-04 08:08:45 PST
Landed in r54339, no new failures observed on the bots
Note You need to log in before you can comment on or make changes to this bug.