Bug 33708

Summary: [Qt] Custom select popups usage example.
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: girish, hausmann, kenneth, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 33418    
Bug Blocks:    
Attachments:
Description Flags
proposed patch.
none
proposed patch.
none
Usage example none

Luiz Agostini
Reported 2010-01-15 01:41:59 PST
Custom select popups usage example.
Attachments
proposed patch. (13.49 KB, patch)
2010-01-15 02:45 PST, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
proposed patch. (13.32 KB, patch)
2010-01-18 14:53 PST, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Usage example (13.34 KB, patch)
2010-01-20 07:15 PST, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-01-15 02:45:05 PST
Created attachment 46661 [details] proposed patch.
WebKit Review Bot
Comment 2 2010-01-15 02:47:11 PST
Attachment 46661 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/qt/QGVLauncher/main.cpp:35: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/qt/QGVLauncher/custompopup.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2
Luiz Agostini
Comment 3 2010-01-15 02:49:07 PST
(In reply to comment #2) > Attachment 46661 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKit/qt/QGVLauncher/main.cpp:35: Found other header before WebCore config.h. > Should be: config.h, primary header, blank line, and then alphabetically > sorted. [build/include_order] [4] > WebKit/qt/QGVLauncher/custompopup.cpp:21: Found header this file implements > before WebCore config.h. Should be: config.h, primary header, blank line, and > then alphabetically sorted. [build/include_order] [4] > Total errors found: 2 I will ignore those style problems because those files are in QGVLauncher and cannot include config.h.
WebKit Review Bot
Comment 4 2010-01-15 04:58:11 PST
Attachment 46661 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/190140
Luiz Agostini
Comment 5 2010-01-15 05:05:24 PST
(In reply to comment #4) > Attachment 46661 [details] did not build on qt: > Build output: http://webkit-commit-queue.appspot.com/results/190140 The build did not succeeded because this bug depends on bug 33418.
Luiz Agostini
Comment 6 2010-01-18 14:53:33 PST
Created attachment 46856 [details] proposed patch. Adaptation to the new API proposal.
WebKit Review Bot
Comment 7 2010-01-18 14:59:06 PST
Attachment 46856 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/qt/QGVLauncher/main.cpp:35: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/qt/QGVLauncher/custompopup.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style.
Luiz Agostini
Comment 8 2010-01-18 15:09:21 PST
(In reply to comment #7) > Attachment 46856 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKit/qt/QGVLauncher/main.cpp:35: Found other header before WebCore config.h. > Should be: config.h, primary header, blank line, and then alphabetically > sorted. [build/include_order] [4] > WebKit/qt/QGVLauncher/custompopup.cpp:21: Found header this file implements > before WebCore config.h. Should be: config.h, primary header, blank line, and > then alphabetically sorted. [build/include_order] [4] > Total errors found: 2 > > > If any of these errors are false positives, please file a bug against > check-webkit-style. those style errors were expected.
WebKit Review Bot
Comment 9 2010-01-18 20:29:17 PST
Attachment 46856 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/198350
Luiz Agostini
Comment 10 2010-01-18 23:21:09 PST
(In reply to comment #9) > Attachment 46856 [details] did not build on qt: > Build output: http://webkit-commit-queue.appspot.com/results/198350 The build did not succeeded because this bug depends on bug 33418
Luiz Agostini
Comment 11 2010-01-20 07:15:10 PST
Created attachment 47025 [details] Usage example Will wait until dependencies are there.
Luiz Agostini
Comment 12 2010-01-29 06:33:48 PST
As the public API was canceled this example is now invalid.
Note You need to log in before you can comment on or make changes to this bug.