Bug 33638

Summary: REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2010-01-13 16:32:44 PST
REGRESSION(53133): commit-queue no longer rejects patches with invalid committers it simply ignores them. It logs a message to the commit-queue logs, but doesn't actually update the bug to say it was rejected. I expect this came of my Attachment refactoring: http://trac.webkit.org/changeset/53133
Attachments
Patch (17.88 KB, patch)
2010-01-14 16:14 PST, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-01-14 01:53:29 PST
This is worse than expected. I think that this causes the commit queue to spin. It doesn't process the patch and I think that it ends up "thinking" that it's empty and waiting another 5 minutes after the failed processing instead of correcting rejecting the patch from the queue and moving on. So right now someone setting an commit-queue or review flag w/o having proper permissionss looks like it will HANG the queue! I think the commit-queue was delayed for a day due to this bug!
Eric Seidel (no email)
Comment 2 2010-01-14 13:58:02 PST
I'm working on a fix now.
Eric Seidel (no email)
Comment 3 2010-01-14 16:14:26 PST
Created attachment 46618 [details] Patch
Eric Seidel (no email)
Comment 4 2010-01-14 16:16:01 PST
I fixed the bug, and then realizing that I had to pile yet another hack into MockBugzillaTool, so I ended up fixing MockBugzillaTool too use a more dynamic system for handling mock bugs and attachments.
Adam Barth
Comment 5 2010-01-14 16:19:52 PST
Comment on attachment 46618 [details] Patch Nice and epic!
Eric Seidel (no email)
Comment 6 2010-01-14 16:50:46 PST
Committed r53298: <http://trac.webkit.org/changeset/53298>
Note You need to log in before you can comment on or make changes to this bug.