Bug 33310

Summary: editing/pasteboard/4641033.html timed out on Tiger Bot
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cjerdonek, commit-queue, justin.garcia
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 33289    
Attachments:
Description Flags
Patch
none
Patch dglazkov: review+, commit-queue: commit-queue-

Eric Seidel (no email)
Reported 2010-01-07 00:46:39 PST
editing/pasteboard/4641033.html timed out on Tiger Bot This is the first time I've noticed this timeout: http://build.webkit.org/results/Tiger%20Intel%20Release/r52905%20(7498)/results.html This test has been here forever: http://trac.webkit.org/browser/trunk/LayoutTests/editing/pasteboard/4641033.html
Attachments
Patch (1.89 KB, patch)
2010-01-15 12:15 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (1.01 KB, patch)
2010-01-20 15:45 PST, Eric Seidel (no email) 		dglazkov: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-01-10 20:32:26 PST
This seems to be one of the more common tiger failures. I've seen in a couple times this week, including just now: http://build.webkit.org/results/Tiger%20Intel%20Release/r53059%20(7616)/results.html
Eric Seidel (no email)
Comment 2 2010-01-12 12:06:08 PST
This still times out every 5 to 10 builds or so on Tiger: http://build.webkit.org/results/Tiger%20Intel%20Release/r53142%20(7670)/results.html If we don't have any theories, we should just skip this test. I get the impression that Tiger support is slowly being deprecated anyway.
Eric Seidel (no email)
Comment 3 2010-01-12 12:07:43 PST
I see no reason why this test should be failing unless copy or paste is hanging or unless the DRT timeout machinery is somehow broken on tiger.
Eric Seidel (no email)
Comment 4 2010-01-12 12:39:10 PST
I think this test could be re-written to use onload (I think it's trying to wait for the img to load) and possibly be dumpAsText. I might try that.
Eric Seidel (no email)
Comment 5 2010-01-15 12:15:10 PST
Created attachment 46697 [details] Patch
Eric Seidel (no email)
Comment 6 2010-01-15 12:16:48 PST
I also wonder if the extra </select> close tag could be related to the failure here. I think the selection might unintentionally end up including the <script> tag and we might be copy/pasting the script tag. Not sure.
Alexey Proskuryakov
Comment 7 2010-01-15 12:28:48 PST
Comment on attachment 46697 [details] Patch I'm not sure if setTimeout is unnecessary - the original bug was about DOM traversal and presence or renderers, and the DOM is different when still parsing. If this isn't going to fix the problem, better not make arbitrary changes. One possible reason for the test to time out would be an exception being raised. Maybe you could add a try/catch block instead, and log the exception?
Eric Seidel (no email)
Comment 8 2010-01-15 14:07:59 PST
Exceptions would show up in the stderr. So I don't think exceptions are involved here. Do we have any idea what this test is actually supposed to be about? It's not at all clear from the test.
Eric Seidel (no email)
Comment 9 2010-01-15 14:08:40 PST
I think if we don't understand the test, we should consider skipping it on Tiger, or removing it from the repository in total. :)
Alexey Proskuryakov
Comment 10 2010-01-15 15:57:28 PST
Did we get to see stderr? All I see is "file not found".
Eric Seidel (no email)
Comment 11 2010-01-20 15:45:02 PST
Created attachment 47074 [details] Patch
Eric Seidel (no email)
Comment 12 2010-01-24 22:44:00 PST
run-webkit-tests often makes a stderr link even though there is no stderr file. At least that's my understanding. It's a bug we should fix some day.
Eric Seidel (no email)
Comment 13 2010-01-24 23:19:00 PST
Another timeout: http://build.webkit.org/results/Tiger%20Intel%20Release/r53789%20(8117)/results.html
Dimitri Glazkov (Google)
Comment 14 2010-02-17 19:20:39 PST
Comment on attachment 47074 [details] Patch ok.
WebKit Commit Bot
Comment 15 2010-02-17 22:53:02 PST
Comment on attachment 47074 [details] Patch Rejecting patch 47074 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov', '--force']" exit_code: 1 patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac-tiger/Skipped Hunk #1 FAILED at 98. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-tiger/Skipped.rej Full output: http://webkit-commit-queue.appspot.com/results/283139
Eric Seidel (no email)
Comment 16 2010-02-19 16:22:53 PST
Attachment 47074 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Eric Seidel (no email)
Comment 17 2010-02-19 16:46:05 PST
Committed r55038: <http://trac.webkit.org/changeset/55038>
Note You need to log in before you can comment on or make changes to this bug.