Bug 32995

Summary: Add the start of a Bug object for bugzilla.py
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 33009    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2009-12-28 14:34:21 PST
Add the start of a Bug object for bugzilla.py I also fixed the __all__ issue for buildsteps.py, but I can split that out into a separate change if necessary.
Attachments
Patch (12.46 KB, patch)
2009-12-28 15:23 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-12-28 15:23:05 PST
Created attachment 45578 [details] Patch
WebKit Review Bot
Comment 2 2009-12-28 15:28:18 PST
style-queue ran check-webkit-style on attachment 45578 [details] without any errors.
Adam Barth
Comment 3 2009-12-29 10:58:07 PST
Comment on attachment 45578 [details] Patch Certainly not the last word, but progress nonetheless. W.r.t. not all the steps having "Step" in their names: that's just a mistake. We should put them into a step module and call then step.Commit and step.EnsureBuildersAreGreen. The "build" in buildsteps is a misnomer now.
WebKit Commit Bot
Comment 4 2009-12-29 11:03:23 PST
Comment on attachment 45578 [details] Patch Rejecting patch 45578 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11854 test cases. fast/css/non-standard-checkbox-size.html -> failed Exiting early after 1 failures. 5218 tests run. 76.31s total testing time 5217 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/150775
Eric Seidel (no email)
Comment 5 2009-12-29 11:08:09 PST
The failure is bogus. The test was added by bug 28631. This is due to bug 28603.
Eric Seidel (no email)
Comment 6 2009-12-29 11:17:19 PST
Comment on attachment 45578 [details] Patch Sorry. We were bit by bug 28603. I've fixed the commit bot for now.
WebKit Commit Bot
Comment 7 2009-12-29 11:33:12 PST
Comment on attachment 45578 [details] Patch Clearing flags on attachment: 45578 Committed r52628: <http://trac.webkit.org/changeset/52628>
WebKit Commit Bot
Comment 8 2009-12-29 11:33:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.