Bug 32898

Summary: [Qt] Add page zooming support to Qt DumpRenderTree
Product: WebKit Reporter: Kim Grönholm <kim.1.gronholm>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: arabelo, diegohcg, petri.latvala, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 32899    
Attachments:
Description Flags
Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list
none
Proposed patch v0.2 kenneth: review+, kenneth: commit-queue-

Kim Grönholm
Reported 2009-12-23 04:11:57 PST
Add zoomPageIn() and zoomPageOut() functions to Qt EventSender. Remove the layout tests depending on these functions from the QtWebKit Skipped list.
Attachments
Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list (3.95 KB, patch)
2009-12-23 04:18 PST, Kim Grönholm 		no flags
DetailsFormatted DiffDiff
Proposed patch v0.2 (4.02 KB, patch)
2010-01-06 12:29 PST, Diego Gonzalez 		kenneth: review+
kenneth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kim Grönholm
Comment 1 2009-12-23 04:18:28 PST
Created attachment 45430 [details] Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list Added a patch to fix this issue. One of the tests needed minor refactoring because it failed due to "layoutTestController.notifyDone();" stopping the execution and therefore the lines: PASS successfullyParsed is true TEST COMPLETE never got outputted. I mimic some other tests and changed it accordingly and now it works.
WebKit Review Bot
Comment 2 2009-12-23 04:20:11 PST
style-queue ran check-webkit-style on attachment 45430 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-23 13:18:23 PST
Comment on attachment 45430 [details] Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list I don't understand the re-ordering in clientXY-in-zoom-and-scroll.html
Eric Seidel (no email)
Comment 4 2010-01-05 13:48:03 PST
Comment on attachment 45430 [details] Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list I don't understand the change to: LayoutTests/fast/events/clientXY-in-zoom-and-scroll.html otherwise this looks fine. Could you please explain? Ideally updating the changelog with an explanation?
Diego Gonzalez
Comment 5 2010-01-06 12:29:06 PST
Created attachment 45979 [details] Proposed patch v0.2 It's a possible solution based on Kim Grönholm patch without any modification in clientXY-in-zoom-and-scroll.html file. This patch also enable two skipped tests (fast/events/clientXY-in-zoom-and-scroll.html and fast/dom/elementFromPoint-relative-to-viewport.html). The test caretRangeFromPoint-in-zoom-and-scroll.html was rearranged in the Skipped file because it's still failing even with zoomPageIn and zoomPageOut implementation.
Antonio Gomes
Comment 6 2010-01-06 12:32:20 PST
LGTM
Kenneth Rohde Christiansen
Comment 7 2010-01-06 12:35:45 PST
Comment on attachment 45979 [details] Proposed patch v0.2 > + Patch by Kim Grönholm <kim.gronholm@nomovok.com>, Please make sure his name is written correct. Did you upload the patch with bugzilla-tool? > > +#define ZOOM_STEP 1.2 > Why 1.2 and not 1.3? Please add a comment explaining why (required by DRT?)
Antonio Gomes
Comment 8 2010-01-06 20:03:16 PST
r52897
Note You need to log in before you can comment on or make changes to this bug.