Bug 32696

Summary: HTMLInputElement::valueAsNumber support
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-valueasnumber
Bug Depends on: 32697    
Bug Blocks: 19264, 29070, 30847, 34200, 34240    
Attachments:
Description Flags
Proposed patch darin: review+

Kent Tamura
Reported 2009-12-17 22:03:26 PST
It is helpful to implement min/max/step attribute for the date&time types.
Attachments
Proposed patch (55.41 KB, patch)
2010-01-26 01:24 PST, Kent Tamura 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-01-26 01:24:12 PST
Created attachment 47393 [details] Proposed patch
Kent Tamura
Comment 2 2010-01-26 01:25:40 PST
Add Darin to cc, who reviewed all of patches for valueAsDate. valueAsDate is very related to valueAsNumber.
Darin Adler
Comment 3 2010-01-26 09:01:49 PST
Comment on attachment 47393 [details] Proposed patch > + const double nan = std::numeric_limits<double>::quiet_NaN(); Normally we omit the "std" for things like this, and have "using namespace std" at the top of the file. r=me
Kent Tamura
Comment 4 2010-01-26 20:46:40 PST
(In reply to comment #3) > (From update of attachment 47393 [details]) > > + const double nan = std::numeric_limits<double>::quiet_NaN(); > > Normally we omit the "std" for things like this, and have "using namespace std" > at the top of the file. Removed std::, and landed as r53893.
Brian Weinstein
Comment 5 2010-01-27 16:24:16 PST
This test failed on Windows since it was created. Landed expected failing results for Windows in r53959.
Kent Tamura
Comment 6 2010-01-27 16:39:24 PST
(In reply to comment #5) > This test failed on Windows since it was created. Landed expected failing > results for Windows in r53959. I'll investigate it today.
Kent Tamura
Comment 7 2010-01-27 20:45:24 PST
(In reply to comment #6) > (In reply to comment #5) > > This test failed on Windows since it was created. Landed expected failing > > results for Windows in r53959. > > I'll investigate it today. I made a bug entry for the failure: Bug#34240.
Note You need to log in before you can comment on or make changes to this bug.