Bug 32607

Summary: [Qt] Code cleanup: Make better separation between QJavaScript's "public" and "private" classes
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED INVALID    
Severity: Normal CC: jedrzej.nowacki, kent.hansen
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 32565    
Bug Blocks: 32608, 32657    
Attachments:
Description Flags
patch v1 jedrzej.nowacki: review-, jedrzej.nowacki: commit-queue-

Jędrzej Nowacki
Reported 2009-12-16 05:45:57 PST
The QJavaScript API implementation is small enough to keep clear separation between a "public" and a "private" classes. For implementation simplicity we should assume that a "public" class should only propagate functions calls and convert a data (from "private" to "public" and from "public" to "private"). The bug apply only if the bug 32565 will be accepted to commit.
Attachments
patch v1 (4.49 KB, patch)
2009-12-16 05:51 PST, Jędrzej Nowacki 		jedrzej.nowacki: review-
jedrzej.nowacki: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jędrzej Nowacki
Comment 1 2009-12-16 05:51:53 PST
Created attachment 44966 [details] patch v1 The patch should be landed after bug 32565.
Jędrzej Nowacki
Comment 2 2010-01-04 06:29:25 PST
The base patch (bug 32565) wasn't accepted, so the bug is not valid.
Note You need to log in before you can comment on or make changes to this bug.