Bug 31092

Summary: bugzilla-tool crashed with exception
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 30683    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2009-11-03 16:35:48 PST
From Adam: File "/Users/abarth/git/webkit/WebKitTools/Scripts/modules/bugzilla.py", line 227, in _validate_setter_email log("Warning, attachment %s on bug %s has invalid %s (%s)", (patch['id'], patch['bug_id'], result_key, setter_email)) TypeError: log() takes exactly 1 argument (2 given) Fix coming up.
Attachments
Patch (1.42 KB, patch)
2009-11-03 16:36 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-11-03 16:36:44 PST
Created attachment 42436 [details] Patch
Adam Barth
Comment 2 2009-11-03 22:58:54 PST
Comment on attachment 42436 [details] Patch Sorry, I should have caught that in an earlier code review, I'm sure.
WebKit Commit Bot
Comment 3 2009-11-04 01:23:46 PST
Comment on attachment 42436 [details] Patch Rejecting patch 42436 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: tting to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebKitTools/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469
Eric Seidel (no email)
Comment 4 2009-11-04 01:25:35 PST
svn-apply (and thus the commit-queue) can't handle this diff due to bug 30683. Hopefully that will land soon, otherwise I can land this manually.
Eric Seidel (no email)
Comment 5 2009-11-04 22:19:33 PST
Comment on attachment 42436 [details] Patch Try again now that bug 30683 is in the queue to be landed.
WebKit Commit Bot
Comment 6 2009-11-04 22:59:46 PST
Comment on attachment 42436 [details] Patch Rejecting patch 42436 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: tting to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebKitTools/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469
Eric Seidel (no email)
Comment 7 2009-11-05 08:49:39 PST
Strange. Now that bug 30683 is fixed, this should land correctly. I'll investigate.
Eric Seidel (no email)
Comment 8 2009-11-06 11:41:27 PST
Comment on attachment 42436 [details] Patch bugzilla-tool apply-patches worked just fine, so I assume the commit-queue's svn-apply just hadn't been updated yet when I last queued this. We'll try on last time.
WebKit Commit Bot
Comment 9 2009-11-06 11:53:27 PST
Comment on attachment 42436 [details] Patch Clearing flags on attachment: 42436 Committed r50602: <http://trac.webkit.org/changeset/50602>
WebKit Commit Bot
Comment 10 2009-11-06 11:53:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.