Bug 31088

Summary:

Add overridePreference call to all WebGL layout tests

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, mrowe, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	oliver: review-
Patch	oliver: review-
Patch	oliver: review+, oliver: commit-queue-

Kenneth Russell

Reported 2009-11-03 15:02:15 PST

The WebGL layout tests all need the call if (window.layoutTestController) layoutTestController.overridePreference("WebKitWebGLEnabled", "1"); as a prologue. This bit is sticky across runs, but an initial run with this bit unset causes the layout tests to fail with the error "TypeError: Result of expression 'context' [undefined] is not an object."

Attachments
Patch (2.57 KB, patch) 2009-11-03 15:08 PST, Kenneth Russell	oliver: review-	Details Formatted Diff Diff
Patch (4.50 KB, patch) 2009-11-03 15:40 PST, Kenneth Russell	oliver: review-	Details Formatted Diff Diff
Patch (7.69 KB, patch) 2009-11-03 15:51 PST, Kenneth Russell	oliver: review+ oliver: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kenneth Russell

Comment 1 2009-11-03 15:08:18 PST

Created attachment 42424 [details] Patch

Oliver Hunt

Comment 2 2009-11-03 15:14:22 PST

Comment on attachment 42424 [details] Patch This should just be put in one place, the shader-test.js test prefix

Kenneth Russell

Comment 3 2009-11-03 15:40:07 PST

Created attachment 42430 [details] Patch Replacement patch factoring this call into new webgl-test.js for sharing among more tests.

Oliver Hunt

Comment 4 2009-11-03 15:42:06 PST

Comment on attachment 42430 [details] Patch There's no reason to use a separate file -- if absolutely necessary rename shader-test.js to webgl-test.js that way each test doesn't end up needing to include multiple files

Kenneth Russell

Comment 5 2009-11-03 15:51:22 PST

Created attachment 42433 [details] Patch Patch renaming shader-test.js to webgl-test.js, adding necessary code, and updating references from tests.

Mark Rowe (bdash)

Comment 6 2009-11-03 16:18:22 PST

(In reply to comment #0) > The WebGL layout tests all need the call > > if (window.layoutTestController) > layoutTestController.overridePreference("WebKitWebGLEnabled", "1"); > > as a prologue. This bit is sticky across runs, but an initial run with this bit > unset causes the layout tests to fail with the error > > "TypeError: Result of expression 'context' [undefined] is not an object.” Can you clarify what you mean by “This bit is sticky across runs”?

Kenneth Russell

Comment 7 2009-11-03 16:22:37 PST

It appears that if a test is run once under DumpRenderTree and the overridePreference is executed, then subsequent runs will work even if the overridePreference call is not in place. In other words, the effect is similar to the "defaults write" command currently used to enable WebGL in WebKit nightly builds.

Mark Rowe (bdash)

Comment 8 2009-11-03 16:27:44 PST

(In reply to comment #7) > It appears that if a test is run once under DumpRenderTree and the > overridePreference is executed, then subsequent runs will work even if the > overridePreference call is not in place. In other words, the effect is similar > to the "defaults write" command currently used to enable WebGL in WebKit > nightly builds. That sounds like a bug in DRT. It should be resetting preferences to a consistent state between tests, not letting them persist.

Oliver Hunt

Comment 9 2009-11-03 17:26:17 PST

Committed r50492

Kenneth Russell

Comment 10 2009-11-04 10:49:54 PST

(In reply to comment #8) > (In reply to comment #7) > > It appears that if a test is run once under DumpRenderTree and the > > overridePreference is executed, then subsequent runs will work even if the > > overridePreference call is not in place. In other words, the effect is similar > > to the "defaults write" command currently used to enable WebGL in WebKit > > nightly builds. > > That sounds like a bug in DRT. It should be resetting preferences to a > consistent state between tests, not letting them persist. After looking into this a little further, the overridePreference setting isn't sticky across runs, but if ObjC code was ever used to force this preference to true in the context of DumpRenderTree (and it looks like this was done on some of the developers' machines) then it is persistent. I've filed DumpRenderTree can retain preferences state across runs https://bugs.webkit.org/show_bug.cgi?id=31129

Note You need to log in before you can comment on or make changes to this bug.