Bug 30680
| Summary: | media/audio-delete-while-step-button-clicked.html test has hard-coded values | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alejandro G. Castro <alex> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | eric.carlson, eric, pnormand, xan.lopez |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
Alejandro G. Castro
In gtk port we have detected a situation where the click on the UI controls goes to the audio node but it does not hit any button, in this case the test fails:
...
var right = audio.offsetLeft + audio.offsetWidth;
var bottom = audio.offsetTop + audio.offsetHeight;
var x = right - 8;
var y = bottom - 8;
...
Probably we should move this test to Apple specific and each platform should create one depending on the layout of the buttons. With Gtk+ this code works:
...
var x = right - 17;
var y = bottom - 8;
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Can we just find the middle of the element? Or use some more flexible math here?
Eric Carlson
https://bugs.webkit.org/show_bug.cgi?id=28220 is about exactly this problem, though I don't have a solution for the problem yet.
Philippe Normand
*** Bug 30247 has been marked as a duplicate of this bug. ***
Philippe Normand
*** This bug has been marked as a duplicate of bug 28220 ***