Bug 30630

Summary: [Qt] QWebElement::removeChildren() should be QWebElement::removeAllChildren()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, kenneth, vestbo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 29843    

Benjamin Poulain
Reported 2009-10-21 07:25:52 PDT
The usual prefix to remove the all the elements of a collection is "removeAll", not "remove". E.g. QWebDatabase::removeAllDatabases() QUrl::removeAllQueryItems(). QWebElement::removeChildren() should be QWebElement::removeAllChildren() for consistency.
Attachments
Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2009-10-26 10:29:42 PDT
I'm fully OK with that.
Tor Arne Vestbø
Comment 2 2009-10-27 06:46:10 PDT
Me too
Kenneth Rohde Christiansen
Comment 3 2009-10-27 07:23:00 PDT
Landed in 50147
Note You need to log in before you can comment on or make changes to this bug.