Bug 30530

Summary:

Replace QWebFrame::clipContentsToViewport with better API

Product:

WebKit

Reporter:

Kenneth Rohde Christiansen <kenneth>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, rich

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

29843

Attachments:

Description	Flags
First part of the clipContentsToViewport fix (introduce paint method, deprecate render)	none
Second version incorporating feedback from IRC	none

Kenneth Rohde Christiansen

Reported 2009-10-19 13:37:40 PDT

Created attachment 41444 [details] First part of the clipContentsToViewport fix (introduce paint method, deprecate render) We had a quick round of API review with Matthias here at the DevDays and came up with the following suggestions for changes: * QWebFrame::clipContentsToViewport: 1) Remove the property 2) Deprecate QWebFrame::render() 3) Introduce QWebFrame::paint(QWebFrame::PaintOptions opts = QWebFrame::AllElements), so that one can for eaxmple call frame->paint(QWebFrame::Contents); frame->paint(QWebFrame::Contents | QWebFrame::ScrollBars);

Attachments
First part of the clipContentsToViewport fix (introduce paint method, deprecate render) (6.32 KB, patch) 2009-10-19 13:37 PDT, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Second version incorporating feedback from IRC (6.45 KB, patch) 2009-10-19 14:42 PDT, Kenneth Rohde Christiansen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kenneth Rohde Christiansen

Comment 1 2009-10-19 13:40:04 PDT

Follow up patch will remove the clipContentsToViewport property

Tor Arne Vestbø

Comment 2 2009-10-19 14:05:27 PDT

Comment on attachment 41444 [details] First part of the clipContentsToViewport fix (introduce paint method, deprecate render) Let's discuss this further before landing

Kenneth Rohde Christiansen

Comment 3 2009-10-19 14:42:36 PDT

Created attachment 41454 [details] Second version incorporating feedback from IRC

Richard Moore

Comment 4 2009-10-19 15:46:28 PDT

Might be worth considering making the numbers for the enum a bit bigger so that if you later want to add intermediate layers they can still have an id that reflects the stacking order. eg. 0x10, 0x20 etc. instead of 0x01, 0x02.

Kenneth Rohde Christiansen

Comment 5 2009-10-20 13:16:51 PDT

Landed in 49850

Eric Seidel (no email)

Comment 6 2009-10-21 10:40:02 PDT

Comment on attachment 41454 [details] Second version incorporating feedback from IRC Supposedly this patch was landed, so removing r?.

Note You need to log in before you can comment on or make changes to this bug.