Bug 29319

Summary:

Reorganizing helper functions in htmlediting.h

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

HTML Editing

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch2	eric: review+, eric: commit-queue-
New patch including feedback from review	eric: review+, eric: commit-queue+

Enrica Casucci

Reported 2009-09-16 16:33:04 PDT

Reorganizing helper functions in htmlediting.h to group them by type of object they return/operate upon.

Attachments
Patch (13.75 KB, patch) 2009-09-16 16:39 PDT, Enrica Casucci	no flags	Details Formatted Diff Diff
Patch2 (13.46 KB, patch) 2009-09-16 17:02 PDT, Enrica Casucci	eric: review+ eric: commit-queue-	Details Formatted Diff Diff
New patch including feedback from review (13.50 KB, patch) 2009-09-16 17:31 PDT, Enrica Casucci	eric: review+ eric: commit-queue+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Enrica Casucci

Comment 1 2009-09-16 16:39:30 PDT

Created attachment 39665 [details] Patch

Enrica Casucci

Comment 2 2009-09-16 17:02:35 PDT

Created attachment 39666 [details] Patch2

Eric Seidel (no email)

Comment 3 2009-09-16 17:12:40 PDT

Comment on attachment 39666 [details] Patch2 Welcome to WebKit! :) Seems there is an extra newline after isAtUnsplittableElement. I wonder why this doesn't return HTMLElement: 118202 PassRefPtr<Element> createTabSpanElement(Document*); (You shouldn't change it now, just noting.) Space after a period? 15 (WebCore::isAtUnsplittableElement): added.The code has been taken from IndentOutdentCommand. This looks fine though. Either you can get someone to commit this for you with modifications, or you can post a new patch with the spacing fixed and the commit queue could take care of this. Your call.

Eric Seidel (no email)

Comment 4 2009-09-16 17:13:48 PDT

15 (WebCore::isAtUnsplittableElement): added.The code has been taken from IndentOutdentCommand. Should also probably be "The code was taken from IndentOutdentCommand.cpp". "has been" sounds strange to my ears.

Enrica Casucci

Comment 5 2009-09-16 17:31:25 PDT

Created attachment 39671 [details] New patch including feedback from review

Eric Seidel (no email)

Comment 6 2009-09-16 17:33:37 PDT

Comment on attachment 39671 [details] New patch including feedback from review Well, again welcome. Congrats on your first patch. LGTM.

WebKit Commit Bot

Comment 7 2009-09-16 17:50:39 PDT

Comment on attachment 39671 [details] New patch including feedback from review Rejecting patch 39671 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11266 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8903 tests run. 278.70s total testing time 8902 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output

Eric Seidel (no email)

Comment 8 2009-09-16 18:37:28 PDT

Comment on attachment 39671 [details] New patch including feedback from review I'm very sad this was your first experience with the commit-queue. It looks like you hit a flakey test. I've filed bug 29322 about the flakey test.

WebKit Commit Bot

Comment 9 2009-09-16 18:59:12 PDT

Committed r48448: <http://trac.webkit.org/changeset/48448>

Note You need to log in before you can comment on or make changes to this bug.