Bug 29159

Summary: Undo r47992
Product: WebKit Reporter: Evan Stade <estade>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
revert none

Evan Stade
Reported 2009-09-10 16:25:30 PDT
Darin F has pointed out that we should just use RenderTheme::setCustomFocusRingColor(). This patch should only be committed after http://codereview.chromium.org/195059/show.
Attachments
revert (2.54 KB, patch)
2009-09-10 16:26 PDT, Evan Stade 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Evan Stade
Comment 1 2009-09-10 16:26:23 PDT
Created attachment 39391 [details] revert
Darin Adler
Comment 2 2009-09-10 16:52:12 PDT
Comment on attachment 39391 [details] revert Rolling out a change normally doesn't require review. rs=me
Eric Seidel (no email)
Comment 3 2009-09-10 18:13:18 PDT
estade says this depends on some chromium change so it can't be commit-queued.
WebKit Commit Bot
Comment 4 2009-09-10 18:17:46 PDT
Comment on attachment 39391 [details] revert Rejecting patch 39391 from commit-queue. estade@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Evan Stade
Comment 5 2009-09-11 14:11:21 PDT
Comment on attachment 39391 [details] revert ready for commit
WebKit Commit Bot
Comment 6 2009-09-11 14:34:18 PDT
Comment on attachment 39391 [details] revert Rejecting patch 39391 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Eric Seidel (no email)
Comment 7 2009-09-11 14:35:46 PDT
We were bitten again by bug 28845. :( media/controls-after-reload.html -> crashed I'm working right now on making the error messages nicer.
WebKit Commit Bot
Comment 8 2009-09-11 14:52:33 PDT
Comment on attachment 39391 [details] revert Clearing flags on attachment: 39391 Committed r48317: <http://trac.webkit.org/changeset/48317>
WebKit Commit Bot
Comment 9 2009-09-11 14:52:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.