Bug 291354
| Summary: | [WPE] WPE Platform: unknown annotations preventing to build WPE Platform | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Guillaume Desmottes <gdesmott> |
| Component: | WPE WebKit | Assignee: | Patrick Griffis <pgriffis> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, pgriffis |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Bug Depends on: | |||
| Bug Blocks: | 265636 | ||
Guillaume Desmottes
I'm trying to enable WPE Plateform in the wpewebkit Debian package but the build failed because of this error:
Source/WebKit/WPEPlatform/wpe/WPEBufferDMABufFormats.cpp:228: Warning: WPEPlatform: unknown annotation: copy-func
Source/WebKit/WPEPlatform/wpe/WPEBufferDMABufFormats.cpp:228: Warning: WPEPlatform: unknown annotation: free-func
<unknown>:: Fatal: WPEPlatform: warnings configured as fatal
<unknown>:: Fatal: WPEPlatform: warnings configured as fatal
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Patrick Griffis
These were added in gobject-introspection 1.74.
`WPEBufferDMABufFormatsBuilder` is a Boxed type though, so I would have assumed they are not needed.
Patrick Griffis
Pull request: https://github.com/WebKit/WebKit/pull/43905
Patrick Griffis
> I would have assumed they are not needed.
Tested with Python, worked fine.
EWS
Committed 293523@main (7154d371c83d): <https://commits.webkit.org/293523@main>
Reviewed commits have been landed. Closing PR #43905 and removing active labels.