Bug 277586
| Summary: | [WPT import/export friction] Reference tests require added both an untested -ref.html and an -expected.html | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=203784 | ||
Simon Fraser (smfr)
WPT use <link rel="match"> and often share references between tests. WebKit uses one -expected.html per tests. These need to be reconciled (bug 203784) but the current state is annoying and error prone:
* You have to add both the -ref.html and -expected.html, as well as the test, so 3 files per test, potentially.
* The -ref.html and -expected.html may not match, which means an export followed by an import will cause a behavior change.
* There's no local testing that the <link rel="match"> and -ref.html are accurate and produce the expected result.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133105906>
Simon Fraser (smfr)
The mental gyrations required to add new WPT-conformant WPT while also thinking about the WebKit need for -expected.html files are significant.
Some things that would help:
1. Let me add tests using the WPT configuration, then run a script to locally create the webkit expectations.
2. Let me run `run-webkit-tests` in a mode that supports `<link rel="match">`
3. Just support `<link rel="match">` (bug 203784).
Simon Fraser (smfr)
The thing that makes this non-trivial is that many WPT put the reference file in a different directory, or share a ref between multiple tests.