Bug 276028

Summary: Get rid of makeTextFlow constructor
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Layout and RenderingAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 276138    
Bug Blocks:    

Tim Nguyen (:ntim)
Reported 2024-06-28 21:24:57 PDT
The default TextFlow constructor should just be used. The sideways writing mode logic is incorrect in there.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-06-29 04:18:41 PDT
<rdar://problem/130808015>
Tim Nguyen (:ntim)
Comment 2 2024-06-29 04:20:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/30300
EWS
Comment 3 2024-06-29 09:49:36 PDT
Committed 280500@main (e6d038446cca): <https://commits.webkit.org/280500@main> Reviewed commits have been landed. Closing PR #30300 and removing active labels.
WebKit Commit Bot
Comment 4 2024-07-02 12:37:02 PDT
Re-opened since this is blocked by bug 276138
Tim Nguyen (:ntim)
Comment 5 2024-10-22 09:27:52 PDT
*** This bug has been marked as a duplicate of bug 277057 ***
Note You need to log in before you can comment on or make changes to this bug.