Bug 27571

Summary: [CSS3 Backgrounds and Borders] Add support for the "round" value for background-repeat
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 27569    
Attachments:
Description Flags
Patch for the CSS part of round and space
mitz: review-
Updated patch mitz: review+

Dave Hyatt
Reported 2009-07-22 15:40:48 PDT
background-repeat now takes a "round" value that allows you to precisely fit tiles.
Attachments
Patch for the CSS part of round and space (8.56 KB, patch)
2009-08-21 14:47 PDT, Beth Dakin 		mitz: review-
DetailsFormatted DiffDiff
Updated patch (9.16 KB, patch)
2009-08-21 16:17 PDT, Beth Dakin 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2009-08-21 14:47:24 PDT
Created attachment 38397 [details] Patch for the CSS part of round and space Here is a patch for the CSS part of this task. Dan will take on the rendering side later.
mitz
Comment 2 2009-08-21 16:04:56 PDT
Comment on attachment 38397 [details] Patch for the CSS part of round and space This patch makes EFillRepeat values require 3 bits, but does not update the size of the m_repeat member of FillLayer, so assigning to it will clobber the m_composite member. Thus I’m r-’ing. Given bug 28635, I think it will no longer make sense to capture all 16 possible combinations of no-repeat/repeat/space/round with one enum. Instead, I think you should split m_repeat into two fields, one for horizontal repeat and one for vertical repeat. Perhaps you should fix bug 28635 first. Then adding space/round will be simple again (as simple as this patch).
Beth Dakin
Comment 3 2009-08-21 16:17:51 PDT
Created attachment 38409 [details] Updated patch Here is a new patch that fixes the bit field issue in FillLayer.h. Since this patch is ready to go, I would really rather commit it now than wait until after I fix the 2-keywords bug only to rewrite this patch. That one is next though!
Beth Dakin
Comment 4 2009-08-21 16:31:06 PDT
Thanks Dan! Committed r47648.
Note You need to log in before you can comment on or make changes to this bug.