Bug 269749

Summary:	REGRESSION (274957@main): [ MacOS iOS Debug wk2 ] 2x imported/w3c/web-platform-tests/css/css-view-transitions tests are constant crash
Product:	WebKit	Reporter:	Jay Stfleur <j_stfleur>
Component:	New Bugs	Assignee:	Tim Nguyen (:ntim) <ntim>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	Hironori.Fujii, ntim, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=265170 https://bugs.webkit.org/show_bug.cgi?id=269743

Jay Stfleur

Reported 2024-02-19 14:03:43 PST

Description: imported/w3c/web-platform-tests/css/css-view-transitions are constant crashes on debug History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-view-transitions%2Fnew-content-captures-different-size.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-view-transitions%2Fold-content-captures-different-size.html Diff/Image Diff/Crash Log: PRINTED_DIFF or LINK_TO_IMAGE_DIFF or FIRST_FIVE_LINES_OF_CRASH stderr: ASSERTION FAILED: clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType] rendering/RenderLayer.cpp(4554) : Ref<WebCore::ClipRects> WebCore::RenderLayer::updateClipRects(const WebCore::RenderLayer::ClipRectsContext &) 1 0x104021058 WTFCrash 2 0x2df8366f0 WebCore::NetworkResourcesData::ResourceData::hasContent() const 3 0x2e1021e08 WebCore::RenderLayer::updateClipRects(WebCore::RenderLayer::ClipRectsContext const&) 4 0x2e102241c WebCore::RenderLayer::parentClipRects(WebCore::RenderLayer::ClipRectsContext const&) const 5 0x2e1016e88 WebCore::RenderLayer::backgroundClipRect(WebCore::RenderLayer::ClipRectsContext const&) const 6 0x2e101d888 WebCore::RenderLayer::calculateRects(WebCore::RenderLayer::ClipRectsContext const&, WebCore::LayoutRect const&, WebCore::LayoutRect&, WebCore::ClipRect&, WebCore::ClipRect&, WebCore::LayoutSize const&) const 7 0x2e101befc WebCore::RenderLayer::clipRectRelativeToAncestor(WebCore::RenderLayer*, WebCore::LayoutSize, WebCore::LayoutRect const&) const 8 0x2e10182c4 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 9 0x2e1017708 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 10 0x2e1016690 WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 11 0x2e1015754 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 12 0x2e101c268 WebCore::RenderLayer::paintList(WebCore::RenderLayer::LayerList, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 13 0x2e1018684 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 14 0x2e1017708 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 15 0x2e1016690 WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 16 0x2e1015754 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 17 0x2e101c268 WebCore::RenderLayer::paintList(WebCore::RenderLayer::LayerList, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 18 0x2e1018684 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 19 0x2e1017708 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 20 0x2e1016690 WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 21 0x2e1015754 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 22 0x2e1015478 WebCore::RenderLayer::paint(WebCore::GraphicsContext&, WebCore::LayoutRect const&, WebCore::LayoutSize const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>, WebCore::RenderLayer::SecurityOriginPaintPolicy, WebCore::RegionContext*) 23 0x2dff4e7cc WebCore::LocalFrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::RegionContext*) 24 0x2dff4f564 WebCore::LocalFrameView::paintContentsForSnapshot(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::LocalFrameView::SelectionInSnapshot, WebCore::LocalFrameView::CoordinateSpaceForSnapshot) 25 0x2dfef156c WebCore::snapshotFrameRectWithClip(WebCore::LocalFrame&, WebCore::IntRect const&, WTF::Vector<WebCore::FloatRect, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::SnapshotOptions&&) 26 0x2dfef1088 WebCore::snapshotFrameRect(WebCore::LocalFrame&, WebCore::IntRect const&, WebCore::SnapshotOptions&&) 27 0x2dfef19ac WebCore::snapshotNode(WebCore::LocalFrame&, WebCore::Node&, WebCore::SnapshotOptions&&) 28 0x2def9a75c WebCore::ViewTransition::captureOldState() 29 0x2def9a31c WebCore::ViewTransition::setupViewTransition() 30 0x2dec5c55c WebCore::Document::performPendingViewTransitions() 31 0x2e003ee64 WebCore::Page::updateRendering()::$_39::operator()(WebCore::Document&) const com.apple.WebKit.WebContent.Development terminated (pid 29069) for reason: crash LEAK: 1 WebPageProxy stderr: ASSERTION FAILED: clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType] rendering/RenderLayer.cpp(4554) : Ref<WebCore::ClipRects> WebCore::RenderLayer::updateClipRects(const WebCore::RenderLayer::ClipRectsContext &) 1 0x106cdd058 WTFCrash 2 0x2df8366f0 WebCore::NetworkResourcesData::ResourceData::hasContent() const 3 0x2e1021e08 WebCore::RenderLayer::updateClipRects(WebCore::RenderLayer::ClipRectsContext const&) 4 0x2e102241c WebCore::RenderLayer::parentClipRects(WebCore::RenderLayer::ClipRectsContext const&) const 5 0x2e1016e88 WebCore::RenderLayer::backgroundClipRect(WebCore::RenderLayer::ClipRectsContext const&) const 6 0x2e101d888 WebCore::RenderLayer::calculateRects(WebCore::RenderLayer::ClipRectsContext const&, WebCore::LayoutRect const&, WebCore::LayoutRect&, WebCore::ClipRect&, WebCore::ClipRect&, WebCore::LayoutSize const&) const 7 0x2e101befc WebCore::RenderLayer::clipRectRelativeToAncestor(WebCore::RenderLayer*, WebCore::LayoutSize, WebCore::LayoutRect const&) const 8 0x2e10182c4 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 9 0x2e1017708 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 10 0x2e1016690 WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 11 0x2e1015754 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 12 0x2e101c268 WebCore::RenderLayer::paintList(WebCore::RenderLayer::LayerList, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 13 0x2e1018684 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 14 0x2e1017708 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 15 0x2e1016690 WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 16 0x2e1015754 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 17 0x2e101c268 WebCore::RenderLayer::paintList(WebCore::RenderLayer::LayerList, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 18 0x2e1018684 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 19 0x2e1017708 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 20 0x2e1016690 WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 21 0x2e1015754 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 22 0x2e1015478 WebCore::RenderLayer::paint(WebCore::GraphicsContext&, WebCore::LayoutRect const&, WebCore::LayoutSize const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>, WebCore::RenderLayer::SecurityOriginPaintPolicy, WebCore::RegionContext*) 23 0x2dff4e7cc WebCore::LocalFrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::RegionContext*) 24 0x2dff4f564 WebCore::LocalFrameView::paintContentsForSnapshot(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::LocalFrameView::SelectionInSnapshot, WebCore::LocalFrameView::CoordinateSpaceForSnapshot) 25 0x2dfef156c WebCore::snapshotFrameRectWithClip(WebCore::LocalFrame&, WebCore::IntRect const&, WTF::Vector<WebCore::FloatRect, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::SnapshotOptions&&) 26 0x2dfef1088 WebCore::snapshotFrameRect(WebCore::LocalFrame&, WebCore::IntRect const&, WebCore::SnapshotOptions&&) 27 0x2dfef19ac WebCore::snapshotNode(WebCore::LocalFrame&, WebCore::Node&, WebCore::SnapshotOptions&&) 28 0x2def9a75c WebCore::ViewTransition::captureOldState() 29 0x2def9a31c WebCore::ViewTransition::setupViewTransition() 30 0x2dec5c55c WebCore::Document::performPendingViewTransitions() 31 0x2e003ee64 WebCore::Page::updateRendering()::$_39::operator()(WebCore::Document&) const com.apple.WebKit.WebContent.Development terminated (pid 29092) for reason: crash LEAK: 1 WebPageProxy

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-02-19 14:04:10 PST

<rdar://problem/123266095>

Fujii Hironori

Comment 2 2024-02-19 17:18:55 PST

274996@main reverted 274957@main.

Tim Nguyen (:ntim)

Comment 3 2024-02-22 17:44:54 PST

Re-opening for pull request https://github.com/WebKit/WebKit/pull/24986

Tim Nguyen (:ntim)

Comment 4 2024-02-22 17:59:22 PST

https://commits.webkit.org/275001@main was the original gardening linked to this bug

EWS

Comment 5 2024-02-22 18:05:17 PST

Test gardening commit 275213@main (4cb130679b0f): <https://commits.webkit.org/275213@main> Reviewed commits have been landed. Closing PR #24986 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.