Bug 26832

Summary: Generalize special height handling in InlineBox
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: eric
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 3749    
Attachments:
Description Flags
patch: implement proposed renaming
none
patch: renamed to 'virtualHeight' mjs: review+

Roland Steiner
Reported 2009-06-30 00:19:47 PDT
InlineBox contains a bit that is used to mark when a box computes its height differently from the default. This bit is currently used only for SVG (and used instead of virtual methods for performance reasons) and hence named 'm_isSVG'. This bit should have a generic name that fits its purpose so that it can be re-used. The implementation for ruby will make use of this.
Attachments
patch: implement proposed renaming (7.71 KB, patch)
2009-06-30 00:23 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
patch: renamed to 'virtualHeight' (7.40 KB, patch)
2009-06-30 23:22 PDT, Roland Steiner 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2009-06-30 00:22:22 PDT
(In reply to comment #0) Addendum: This of course also applies to all methods that make use of this bit (isSVG, setIsSVG, svgBoxheight). > InlineBox contains a bit that is used to mark when a box computes its height > differently from the default. This bit is currently used only for SVG (and used > instead of virtual methods for performance reasons) and hence named 'm_isSVG'. > > This bit should have a generic name that fits its purpose so that it can be > re-used. > > The implementation for ruby will make use of this. >
Roland Steiner
Comment 2 2009-06-30 00:23:19 PDT
Created attachment 32036 [details] patch: implement proposed renaming
Eric Seidel (no email)
Comment 3 2009-06-30 00:52:36 PDT
Comment on attachment 32036 [details] patch: implement proposed renaming It seems this should still be wrapped in ENABLE(SVG) || ENABLE(RUBY) blocks. maybe m_useVirtualHeight would be more clear? I'm not sure. I'm just not sure what a "special height" is.
Roland Steiner
Comment 4 2009-06-30 23:22:45 PDT
Created attachment 32110 [details] patch: renamed to 'virtualHeight' You're right, 'virtualheight' probably is more clear. Updated patch accordingly.
Maciej Stachowiak
Comment 5 2009-07-06 00:23:14 PDT
Comment on attachment 32110 [details] patch: renamed to 'virtualHeight' r=me
Roland Steiner
Comment 6 2009-07-06 04:11:45 PDT
(In reply to comment #5) Thanks a lot for the review! Can I ask you to commit the patch for me, please?
Eric Seidel (no email)
Comment 7 2009-07-06 15:42:44 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/InlineBox.cpp M WebCore/rendering/InlineBox.h M WebCore/rendering/RenderSVGInline.cpp M WebCore/rendering/RenderSVGInlineText.cpp M WebCore/rendering/RenderSVGText.cpp M WebCore/rendering/SVGInlineFlowBox.h M WebCore/rendering/SVGInlineTextBox.h M WebCore/rendering/SVGRootInlineBox.h Committed r45570 M WebCore/ChangeLog M WebCore/rendering/InlineBox.cpp M WebCore/rendering/RenderSVGInlineText.cpp M WebCore/rendering/SVGInlineTextBox.h M WebCore/rendering/SVGInlineFlowBox.h M WebCore/rendering/RenderSVGText.cpp M WebCore/rendering/RenderSVGInline.cpp M WebCore/rendering/SVGRootInlineBox.h M WebCore/rendering/InlineBox.h r45570 = 0bc3a1356efe435f43de58095372a73b869cb918 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/45570
Note You need to log in before you can comment on or make changes to this bug.