Bug 268218
| Summary: | import-w3c-tests rewrites HTML of tests in a way that impacts at least one test | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, cdumez, gsnedders, rniwa, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=207736 https://bugs.webkit.org/show_bug.cgi?id=207731 https://bugs.webkit.org/show_bug.cgi?id=277793 |
||
Anne van Kesteren
When importing web-platform-tests/html/syntax/parsing/ambiguous-ampersand.html one line ends up being slightly rewritten in a way that impacts the test.
Instead of
<div><a href='?a=b&c=d&a0b=c©=1¬i=n¬=in¬in=∉¬&;& &'>Link</a><p>Text: ?a=b&c=d&a0b=c©=1¬i=n¬=in¬in=∉¬&;& &</p></div>
you get
<div><a href='?a=b&c=d&a0b=c©=1¬i=n¬=in¬in=∉¬&;& &'>Link</a><p>Text: ?a=b&c;=d&a0b;=c©=1¬i;=n¬=in∉=∉¬&;& &</p></div>
This is the result of the _W3CTestConverter class serializing HTML entities in a somewhat uniform way.
I have not tried to determine if this impacts other tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Yeah; the fix for this is the same as the See Also bugs, to just not do the parse/serialize cycle if the test converter doesn't change anything (really the overall fix is Bug 217522, which gets rid of any need for the converter in the first place),
That said, others (especially Alexey) had raised concerns about just dropping it and whether that would lead to other unintended test changes — and that's hard to verify without first having all of WPT up-to-date to then be able to do a second reimport with this fixed.
youenn fablet
We could try to:
1. Disable converter for any test folder that we start importing
2. Manually disable folder by folder the converter (many folders should not be affected at all).
Storing whether to convert or not specific folders could be done in import-expectations.json.
We could start disabling the importer with folders like web-platform-tests/html/syntax/parsing.
Radar WebKit Bug Importer
<rdar://problem/122230507>