Bug 267813
| Summary: | Explore to remove WheelEvent.initWebKitWheelEvent() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | UI Events | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | annevk, a_protyasha, eric, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
It was removed from Blink in 2014.
Prefixed API - https://trac.webkit.org/wiki/PrefixedAPIs <- We should replicate this on docs.webkit.org as well. Good page and would be good to add relevant bug links as well to make it easier for future tracking.
Blink Intent To Remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/h_GoezQ4MQ4/m/Q5abFkhA76sJ
Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=179230
WebKit Source: https://searchfox.org/wubkat/rev/90f2bafbe99f4ab1ec05cd05d975c0bbd9aa3ad4/Source/WebCore/dom/WheelEvent.cpp#89 ,
https://searchfox.org/wubkat/rev/90f2bafbe99f4ab1ec05cd05d975c0bbd9aa3ad4/Source/WebCore/dom/WheelEvent.idl#44
etc.
__
Just wanted to raise, I think it would be good clean-up. Appreciate if someone can share input from 'Apple' perspective whether it is OK to remove or their are still internal usage etc.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
We pass this WPT: https://wpt.fyi/results/uievents/historical.html?label=master&label=experimental&aligned=&q=uievents
I am reading the code etc. wrong or this is just clean-up or used for other purposes but not exposed?
Anne van Kesteren
The WPT is only testing initWheelEvent(), not initWebKitWheelEvent().
Ahmad Saleem
(In reply to Anne van Kesteren from comment #2)
> The WPT is only testing initWheelEvent(), not initWebKitWheelEvent().
https://jsfiddle.net/d7ur5b6m/show
Updated it in above JSFiddle and we fail 'prefixed' one. :-)
Radar WebKit Bug Importer
<rdar://problem/121733957>
Ahmad Saleem
*** Bug 76124 has been marked as a duplicate of this bug. ***
EWS
Committed 274069@main (f50de885e127): <https://commits.webkit.org/274069@main>
Reviewed commits have been landed. Closing PR #23812 and removing active labels.