Bug 26762

Summary:

clean up indentRegion

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

bfulgham, eric, jparent

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
cleans up indentRegion and isolates code dealing with list into a separate function	eric: review-
cleans up indentRegion and adds some utility functions to htmlediting.h/cpp	eric: review+

Ryosuke Niwa

Reported 2009-06-26 14:53:05 PDT

In order to fix 21712, we need to clean up IndentOutdentCommand::indentRegion.

Attachments
cleans up indentRegion and isolates code dealing with list into a separate function (10.36 KB, patch) 2009-06-26 14:55 PDT, Ryosuke Niwa	eric: review-	Details Formatted Diff Diff
cleans up indentRegion and adds some utility functions to htmlediting.h/cpp (45.76 KB, patch) 2009-06-26 18:25 PDT, Ryosuke Niwa	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2009-06-26 14:55:52 PDT

Created attachment 31952 [details] cleans up indentRegion and isolates code dealing with list into a separate function

Eric Seidel (no email)

Comment 2 2009-06-26 16:22:32 PDT

Comment on attachment 31952 [details] cleans up indentRegion and isolates code dealing with list into a separate function Ryosuke and I sat and reviewed this in person. r-. I look forward to your followup patch.

Ryosuke Niwa

Comment 3 2009-06-26 18:25:20 PDT

Created attachment 31963 [details] cleans up indentRegion and adds some utility functions to htmlediting.h/cpp

Eric Seidel (no email)

Comment 4 2009-06-26 19:15:19 PDT

Comment on attachment 31963 [details] cleans up indentRegion and adds some utility functions to htmlediting.h/cpp Looks great.

Eric Seidel (no email)

Comment 5 2009-06-26 19:15:38 PDT

Ryosuke and I went over this in person already too. :)

Eric Seidel (no email)

Comment 6 2009-06-26 19:15:52 PDT

I'll land this later when I'm not walking away from the computer...

Brent Fulgham

Comment 7 2009-06-27 19:45:56 PDT

Assigning for Landing.

Brent Fulgham

Comment 8 2009-06-27 20:14:28 PDT

Landed in http://trac.webkit.org/changeset/45316.

Ryosuke Niwa

Comment 9 2009-07-13 16:10:20 PDT

(In reply to comment #8) > Landed in http://trac.webkit.org/changeset/45316. Thank you for landing my patch.

Note You need to log in before you can comment on or make changes to this bug.