Bug 26658

Summary: Split the Synching portion of LocalStorageArea into its own class
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, dglazkov, fishd, michaeln, playmobil, sam, yael, zwarich
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 25376    
Attachments:
Description Flags
patch v1 fishd: review+

Jeremy Orlow
Reported 2009-06-23 13:42:16 PDT
This is a sub-component of "Bug 25376: Refactor localStorage code for use in multi-process browsers" (https://bugs.webkit.org/show_bug.cgi?id=25376).
Attachments
patch v1 (60.83 KB, patch)
2009-06-23 13:43 PDT, Jeremy Orlow 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-06-23 13:43:36 PDT
Created attachment 31731 [details] patch v1 Split the syncing portions of LocalStorageArea into StorageAreaSync. This name will make more sense in the next patch (in this set) when LocalStorageArea and SessionStorageArea are merged to become simply StorageArea. (Thus the synching portion of StorageArea is in StorageAreaSync.) This looks like a big patch, but really all it's doing is splitting code and patching split-related things up.
Jeremy Orlow
Comment 2 2009-06-23 13:46:14 PDT
Oops, forgot to add everyone from the other bug to the CC list for this one. Brady you're definitely the idea reviewer for this one as well.
Darin Fisher (:fishd, Google)
Comment 3 2009-06-24 16:51:54 PDT
Comment on attachment 31731 [details] patch v1 > Index: WebCore/ChangeLog ... > +2009-06-23 Jeremy Orlow <jorlow@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + nit: please include a bug link. > + * storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp. > + (WebCore::StorageAreaSync::create): nit: it is common practice to delete the list of methods for file copies since they aren't that interesting to the reader of the ChangeLog. Otherwise, R=me
Darin Fisher (:fishd, Google)
Comment 4 2009-06-24 16:56:30 PDT
Landed as http://trac.webkit.org/changeset/45124
Note You need to log in before you can comment on or make changes to this bug.