Bug 266396
| Summary: | [CMake] Allow enabling C++ library assertions if supported | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=245692 https://bugs.webkit.org/show_bug.cgi?id=271737 https://bugs.webkit.org/show_bug.cgi?id=289007 https://bugs.webkit.org/show_bug.cgi?id=289953 |
||
| Bug Depends on: | 287149, 287431, 287477, 287553, 287558 | ||
| Bug Blocks: | |||
Adrian Perez
In bug #245692 the built-in lightweight assertions supported by libc++
have been enabled for the Apple ports. We may want to do the same for
the ports that use CMake.
While at it, consider supporting also GNU libstdc++, which according
to https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html
has a similar feature toggled by the _GLIBCXX_ASSERTIONS macro.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
I've had a half cooked patch for this sitting on a local branch for
months, so it's probably better to iron it out a bit and get it in
shape for submission =)
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/21785
EWS
Committed 290394@main (3b5d8ebc05c0): <https://commits.webkit.org/290394@main>
Reviewed commits have been landed. Closing PR #21785 and removing active labels.