Bug 266279

Summary: GraphicsContext::drawNativeImage has redundant imageSize parameter
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: CanvasAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 16   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=266628
Bug Depends on:    
Bug Blocks: 266215    

Kimmo Kinnunen
Reported 2023-12-12 05:56:41 PST
GraphicsContext::drawNativeImage has redundant imageSize parameter NativeImage knows its size The call also has source rect that defines the part which is sourced
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-12-12 05:57:02 PST
<rdar://problem/119551804>
Kimmo Kinnunen
Comment 2 2023-12-12 06:03:14 PST
Pull request: https://github.com/WebKit/WebKit/pull/21677
EWS
Comment 3 2023-12-13 02:12:29 PST
Committed 271976@main (8cc92b722540): <https://commits.webkit.org/271976@main> Reviewed commits have been landed. Closing PR #21677 and removing active labels.
Tim Horton
Comment 4 2023-12-15 14:58:52 PST
Reopening due to pending revert.
Kimmo Kinnunen
Comment 5 2023-12-19 05:16:26 PST
The reverted patch wasn't hardened enough for bug 266628
Kimmo Kinnunen
Comment 6 2023-12-19 07:12:00 PST
Pull request: https://github.com/WebKit/WebKit/pull/22026
EWS
Comment 7 2023-12-20 02:15:05 PST
Committed 272333@main (f0cddec1574e): <https://commits.webkit.org/272333@main> Reviewed commits have been landed. Closing PR #22026 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.