Bug 264146
| Summary: | [MSE] MediaSource::isEnded is unnecessarily passed to all methods | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 264134 | ||
Jean-Yves Avenard [:jya]
sub-task of bug 264134
Whenever a method is called in the SourceBufferPrivate, the value of MediaSource::isEnded() is passed. But the MediaSourcePrivate was already notified that the MediaSource has been ended and each SourceBufferPrivate keep a reference to the MediaSourcePrivate.
So we can simplify the code and remove some unnecessary methods.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/117899460>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/19940
EWS
Committed 270390@main (b21ca9944221): <https://commits.webkit.org/270390@main>
Reviewed commits have been landed. Closing PR #19940 and removing active labels.