Bug 262891

Summary:	WTF::computeHash() with RefPtr/CheckedPtr hashes the result of implicit boolean conversion
Product:	WebKit	Reporter:	Antti Koivisto <koivisto>
Component:	Web Template Framework	Assignee:	Antti Koivisto <koivisto>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	260925

Antti Koivisto

Reported 2023-10-09 08:16:44 PDT

This can result in terrible hashing if the key contains RefPtrs, for example using ResolverSharingKey = std::tuple<Vector<RefPtr<StyleSheetContents>>, bool, bool>; in Style::Scope.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-10-09 08:17:18 PDT

<rdar://problem/116679372>

Antti Koivisto

Comment 2 2023-10-09 08:21:03 PDT

Pull request: https://github.com/WebKit/WebKit/pull/18842

EWS

Comment 3 2023-10-09 10:27:16 PDT

Committed 269081@main (a7e29096ee47): <https://commits.webkit.org/269081@main> Reviewed commits have been landed. Closing PR #18842 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.