Bug 26207

Summary: Rebaseline the expected image for fast/forms/select-style.html for Mac.
Product: WebKit Reporter: Takeshi Yoshino <tyoshino>
Component: Layout and RenderingAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed fix for 25742
levin: review+
Proposed fix for 26207 (rev 2) levin: review+

Takeshi Yoshino
Reported 2009-06-05 00:33:29 PDT
Rebaseline the expected image for fast/forms/select-style.html for Mac. I had to include this in the following bug, but I forgot. Retry. Bug 25742: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image. https://bugs.webkit.org/show_bug.cgi?id=25742
Attachments
Proposed fix for 25742 (68.51 KB, patch)
2009-06-05 00:34 PDT, Takeshi Yoshino 		levin: review+
DetailsFormatted DiffDiff
Proposed fix for 26207 (rev 2) (68.74 KB, patch)
2009-06-19 00:03 PDT, Takeshi Yoshino 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Takeshi Yoshino
Comment 1 2009-06-05 00:34:06 PDT
Created attachment 30994 [details] Proposed fix for 25742
David Kilzer (:ddkilzer)
Comment 2 2009-06-05 09:01:35 PDT
Running the pixel test for fast/forms/select-style.html on Leopard 10.5.7 doesn't show any issues: $ ./WebKitTools/Scripts/run-webkit-tests --debug --pixel fast/forms/select-style.html [...] ** BUILD SUCCEEDED ** Running tests from /Volumes/Data/WebKit.git/LayoutTests Enabling pixel tests with a tolerance of 0.1% WARNING: Temporarily changing the main display color profile: The colors on your screen will change for the duration of the testing. This allows the pixel tests to have consistent color values across all machines. Testing 1 test cases. fast/forms . 0.57s total testing time all 1 test cases succeeded Are you sure this change is needed?
David Kilzer (:ddkilzer)
Comment 3 2009-06-05 09:02:18 PDT
(In reply to comment #2) > Running the pixel test for fast/forms/select-style.html on Leopard 10.5.7 > doesn't show any issues: This is using ToT WebKit r44471.
Eric Seidel (no email)
Comment 4 2009-06-05 10:35:05 PDT
Seems this is already fixed, per ddkilzer's comments.
Takeshi Yoshino
Comment 5 2009-06-07 23:22:02 PDT
Re-opening... This patch should be still applied. The reason why the run-webkit-tests passes is because select-style-expected.checksum has been already replaced by the patch in Bug 25742. run-webkit-tests doesn't use png file for comparison. It just compares generated image's checksum with the expected checksum. select-style-expected.png is out of date. We should replace or we'll show an incorrect image on test results.
Takeshi Yoshino
Comment 6 2009-06-10 02:19:50 PDT
Comment on attachment 30994 [details] Proposed fix for 25742 Forgot to set review flag
David Levin
Comment 7 2009-06-18 12:58:04 PDT
Comment on attachment 30994 [details] Proposed fix for 25742 It would be nice to mention (in the changelog) that this test needed to be rebaselined due to r43903, which added more to this test. At first, I was wondering why this patch was needed.
Takeshi Yoshino
Comment 8 2009-06-19 00:03:47 PDT
Created attachment 31535 [details] Proposed fix for 26207 (rev 2)
Takeshi Yoshino
Comment 9 2009-06-19 00:06:10 PDT
(In reply to comment #7) > (From update of attachment 30994 [details] [review]) > It would be nice to mention (in the changelog) that this test needed to be > rebaselined due to r43903, which added more to this test. > > At first, I was wondering why this patch was needed. > Added. Sorry for confusing.
David Levin
Comment 10 2009-06-25 10:31:26 PDT
Assign to levin for landing.
David Levin
Comment 11 2009-06-25 13:40:52 PDT
Committed as http://trac.webkit.org/changeset/45187.
Takeshi Yoshino
Comment 12 2009-06-25 19:16:04 PDT
(In reply to comment #11) > Committed as http://trac.webkit.org/changeset/45187. > Thank you.
Note You need to log in before you can comment on or make changes to this bug.