Bug 261468
| Summary: | Basic support for CSS based Ruby in IFC | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> |
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | csaavedra, info, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=261516 | ||
| Bug Depends on: | |||
| Bug Blocks: | 44515 | ||
Antti Koivisto
The current Ruby implementation uses special elements and renderers. Implement CSS based ruby in IFC.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/115370429>
Antti Koivisto
Pull request: https://github.com/WebKit/WebKit/pull/17700
EWS
Committed 267937@main (44bf0d71007c): <https://commits.webkit.org/267937@main>
Reviewed commits have been landed. Closing PR #17700 and removing active labels.
Claudio Saavedra
This is the first commit where the pywebkit tests start failing:
[1673/2234] webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties failed:
Traceback (most recent call last):
File "/app/webkit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 267, in test_convert_prefixed_properties
test_content = self.generate_test_content_properties_and_values(converter.prefixed_properties, converter.prefixed_property_values, 18, test_html)
File "/app/webkit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 394, in generate_test_content_properties_and_values
test_content_property_values = self.generate_test_content(fully_property_values_list, num_test_properties_and_values, 'propvalue', test_content_properties[1])
File "/app/webkit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 398, in generate_test_content
assert num_test <= len(full_list), "can't generate more tests than we have input data for"
AssertionError: can't generate more tests than we have input data for
Not familiar with this, but thought I'd let you know.
Tim Nguyen (:ntim)
*** Bug 44515 has been marked as a duplicate of this bug. ***