Bug 256164
| Summary: | UBSan: Source/WTF/wtf/text/IntegerToStringConversion.h does not fit in an IntegerType | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Seija K. <gfunni234> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ddkilzer, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 167087 | ||
| Bug Blocks: | |||
Seija K.
Although we check that integer is less than 0 before negating it, the
UBSanitizer keeps tripping up at this section. The proper fix would be
to use std::make_unsigned_t<IntegerType> here, to convert the variable
to its unsigned equivalent.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Seija K.
Pull request: https://github.com/WebKit/WebKit/pull/13308
Radar WebKit Bug Importer
<rdar://problem/109040652>
EWS
Committed 263866@main (a83ee572364b): <https://commits.webkit.org/263866@main>
Reviewed commits have been landed. Closing PR #13308 and removing active labels.