Bug 256061
| Summary: | [run-benchmark][WPE] Update cog and minibrowser-wpe browser drivers. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, philn, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 249031 | ||
Carlos Alberto Lopez Perez
At bug 249286 I had the idea of adding a cog-drm browser driver to run-benchmark script to be able to run perf tets on the RPi.
However I realized this doesn't scale well because we will end with several drivers for cog (one for drm, another for wayland, other for gtk4, etc..)
This also will presents problems later on the UI of https://browserperfdash.igalia.com to identify the browser (it makes little sense to have a 'cog-drm' and a 'cog-gtk4' in the browser list there like if those were different browsers.. there is already a GPU field in case of wanting to have the data split by graphics parameters)
So after landing 263463@main it is now possible to specify the platform plugin for Cog via an environment variable.
We can simplify the driver to have only one Cog browser and in the bots we can select which platform plugin to use via the env.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/13253
EWS
Committed 263495@main (3bfd9bb7a457): <https://commits.webkit.org/263495@main>
Reviewed commits have been landed. Closing PR #13253 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/108652798>