Bug 251312

Summary: [ iOS BigSur+ ] fast/loader/stateobjects/popstate-does-not-fire-with-page-cache.html is a flaky failure.
Product: WebKit Reporter: Bri Harris <bharris9>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
text diff none

Bri Harris
Reported 2023-01-27 22:47:55 PST
fast/loader/stateobjects/popstate-does-not-fire-with-page-cache.html is a flaky failure on iOS 16, BigSur and later platforms. HISTORY: https://results.webkit.org/?suite=layout-tests&test=fast%2Floader%2Fstateobjects%2Fpopstate-does-not-fire-with-page-cache.html&limit=10000 Crash Log is attached. CRASH LOG TEXT: @@ -10,8 +10,7 @@ pageshow fired - persisted=false PASS testWindowPopstateFireCount is 0 going back to page 1 in initial state -popstate fired with state null -PASS testWindowPopstateFireCount is 1 +FAIL testWindowPopstateFireCount should be 1. Was 0. PASS successfullyParsed is true
Attachments
text diff (641 bytes, text/plain)
2023-01-27 22:56 PST, Bri Harris 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-01-27 22:48:17 PST
<rdar://problem/104775065>
Bri Harris
Comment 2 2023-01-27 22:54:49 PST
I was able to reproduce this failure on iOS 16 Release ToT as follows: run-webkit-test --ios-simulator fast/loader/stateobjects/popstate-does-not-fire-with-page-cache.html --iteration 100 With the iterations, I was able to reproduce 22 failures. I was able to reproduce this failure on Ventura Release ToT as follows: run-webkit-test fast/loader/stateobjects/popstate-does-not-fire-with-page-cache.html --iteration 100 With the iterations, I was able to reproduce 4 failures of 100.
Bri Harris
Comment 3 2023-01-27 22:56:07 PST
Created attachment 464699 [details] text diff
Bri Harris
Comment 4 2023-01-27 23:06:28 PST
Pull request: https://github.com/WebKit/WebKit/pull/9279
EWS
Comment 5 2023-01-30 08:52:04 PST
Test gardening commit 259561@main (df3d1454d73d): <https://commits.webkit.org/259561@main> Reviewed commits have been landed. Closing PR #9279 and removing active labels.
Bri Harris
Comment 6 2023-01-30 12:16:03 PST
Pull request: https://github.com/WebKit/WebKit/pull/9334
EWS
Comment 7 2023-01-30 12:25:24 PST
Test gardening commit 259581@main (bda96a710d73): <https://commits.webkit.org/259581@main> Reviewed commits have been landed. Closing PR #9334 and removing active labels.
Chris Dumez
Comment 8 2023-01-30 15:50:42 PST
Pull request: https://github.com/WebKit/WebKit/pull/9355
EWS
Comment 9 2023-01-31 16:45:21 PST
Committed 259649@main (67c6a041f39c): <https://commits.webkit.org/259649@main> Reviewed commits have been landed. Closing PR #9355 and removing active labels.
Bri Harris
Comment 10 2023-02-02 12:01:42 PST
Due to test still failing, reopening. Will mark expectations for macOS while this is being investigated.
Bri Harris
Comment 11 2023-02-02 12:15:31 PST
Pull request: https://github.com/WebKit/WebKit/pull/9548
EWS
Comment 12 2023-02-02 12:35:30 PST
Test gardening commit 259774@main (c3714cf7be45): <https://commits.webkit.org/259774@main> Reviewed commits have been landed. Closing PR #9548 and removing active labels.
Chris Dumez
Comment 13 2023-02-03 16:11:42 PST
This is the part that is flaky: ``` function onTestWindowPageShow(event) { debug("pageshow fired - persisted=" + event.persisted); setTimeout(() => { // Should not have fired a popstate event since the navigation wasn't within the same document. shouldBe("testWindowPopstateFireCount", "0"); debug('going back to page 1 in initial state'); setTimeout(function() {testWindow.history.back();}, 0); }, 10); } ``` It seems sometimes `testWindow.history.back()` doesn't cause a back navigation here and the 10ms delay is what makes it flaky. If we don't use a 10ms delay, then it consistently fails.
Chris Dumez
Comment 14 2023-02-03 16:56:59 PST
Pull request: https://github.com/WebKit/WebKit/pull/9637
EWS
Comment 15 2023-02-05 15:03:19 PST
Committed 259873@main (9b11ab322031): <https://commits.webkit.org/259873@main> Reviewed commits have been landed. Closing PR #9637 and removing active labels.
EWS
Comment 16 2023-03-16 14:54:28 PDT
Committed 259548.431@safari-7615-branch (d4a83e5b2618): <https://commits.webkit.org/259548.431@safari-7615-branch> Reviewed commits have been landed. Closing PR #468 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.