Bug 251266

Summary:	[GTK] Use a weak reference of web view in webkitWebViewGetLoadDecisionForIcon
Product:	WebKit	Reporter:	Carlos Garcia Campos <cgarcia>
Component:	WebKitGTK	Assignee:	Carlos Garcia Campos <cgarcia>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply
Priority:	P2	Keywords:	Gtk
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Carlos Garcia Campos

Reported 2023-01-27 06:30:04 PST

We don't want to delay the dispose of a web view because an icon load decision is still pending, so let's use a weak reference instead of a strong one. This fixes memory leaks reported by unit tests with 2022 API now that favicons are enabled by default.

Attachments
Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2023-01-27 06:39:04 PST

Pull request: https://github.com/WebKit/WebKit/pull/9228

EWS

Comment 2 2023-01-27 22:43:54 PST

Committed 259524@main (5757289eb640): <https://commits.webkit.org/259524@main> Reviewed commits have been landed. Closing PR #9228 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.